Repository navigation
ffbs-parker-respondd: count the clients of routing nodes - #61
Merged
Merged
Conversation
gluon-mesh-batman-adv counts the clients in the local translation table of bat0. A routing node is the router of its clients, so their frames stay in br-client and do not go into bat0. The node then sends clients.total 0 or a too low value. While the node routes, set clients.total to the number of unique MACs in the br-client FDB (all ports except bat0 and local-port, active in the last 60 s) and of the stations of the client access points. The clients of other nodes come in through bat0 and do not count.
This was referenced Nov 21, 2026
4 tasks done
awlx
added a commit
to freifunkMUC/site-ffm
that referenced
this pull request
Nov 21, 2026
Includes: - freifunkMUC/community-packages#60: tests: fix ShellCheck SC2317 - freifunkMUC/community-packages#61: count the clients of routing nodes - freifunkMUC/community-packages#66: rx traffic as a second liveness check - freifunkMUC/community-packages#67: report the CLAT traffic through respondd
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
On parker nodes that route their clients, the map shows a client count that is 0 or too low.
gluon-mesh-batman-adv sets
clients.totalto the number of clients in the local translation table ofbat0. A routing node is the router of its clients. Their frames stay inbr-clientand do not go intobat0. Thus the translation table contains only the node itself.Change
While the node routes for its clients (
network.client.protoisstatic),ffbs-parker-responddsetsclients.totalto the number of unique MACs of:br-client: learned entries on all ports exceptbat0andlocal-port, with a frame in the last 60 seconds,network=client,mode=ap) with activity in the last 60 seconds.The clients of other nodes come in through
bat0. They do not count. The count does not use ARP, the IPv6 neighbour table or DHCP leases. These tables contain the clients of other nodes that use this node as router, and they do not contain IPv6-only (CLAT) clients.A mesh-only node keeps the value of gluon-mesh-batman-adv.
clients.wifi*andclients.owe*do not change.Other changes:
libiwinfo,libuci. PKG_VERSION is 2.tests/run.sh: host test for the FDB filter.Tests
Unit test (FDB filter and MAC set, ASan and UBSan):
Result: PASS, 15 of 15 filter cases and the MAC set check. The cases include: port and bridge entries, bat0 and local-port, permanent and self entries, multicast MAC, age limit, and wrong message type or family.
Compile check:
respondd.candclients.ccompile with-Wall -Wextra -Werroragainst the libiwinfo, libuci and respondd headers.Lab test: QEMU mesh lab, 6 nodes (armsr-armv8), image
v2026.11.1-parker5+cp5d8b362-lab. u1 and u2 route. m1 to m4 are mesh-only, and m4 is behind m3. The lab has 12 clients, which include an IPv6-only (CLAT) client on u1.clients.totaldhcp, stock value; after the heal,staticand 4The u1 IPv6 neighbour table had 30 entries at the same time. This shows that a count from ARP or the neighbour table is not correct.
Not tested:
iwinfoassoclist) was not tested with real stations. Only the FDB path was tested.