Repository navigation
ffbs-mesh-vpn-parker: tests: fix ShellCheck SC2317 in Lint workflow - #60
Merged
Merged
Conversation
…ions ShellCheck before 0.10 reports indirectly called functions as SC2317, newer versions as SC2329. The Lint workflow uses an older version.
awlx
added a commit
to freifunkMUC/site-ffm
that referenced
this pull request
Nov 21, 2026
Includes: - freifunkMUC/community-packages#60: tests: fix ShellCheck SC2317 - freifunkMUC/community-packages#61: count the clients of routing nodes - freifunkMUC/community-packages#66: rx traffic as a second liveness check - freifunkMUC/community-packages#67: report the CLAT traffic through respondd
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The Lint workflow fails on
parker-release-2026.11. ShellCheck reports SC2317 ("Command appears to be unreachable") in two test scripts. The functions are called throughtrapor by other test functions, so the findings are false positives.ShellCheck 0.10 and later use SC2329 for this case. The scripts already disable SC2329. The Lint workflow uses an older ShellCheck, which uses SC2317. This change adds SC2317 to the existing directives.
Changed files (test scripts only, not part of the firmware):
ffbs-mesh-vpn-parker/tests/dhcp-authoritative-test.shffbs-mesh-vpn-parker/tests/ra-goodbye-test.shThe test behavior does not change.
Tests
docker run --rm -v "$PWD":/mnt -w /mnt koalaman/shellcheck:v0.9.0 -S style ffbs-mesh-vpn-parker/tests/dhcp-authoritative-test.sh ffbs-mesh-vpn-parker/tests/ra-goodbye-test.shshellcheck -S style ffbs-mesh-vpn-parker/tests/*.sh(ShellCheck 0.11.0): no findings.docker run --rm -v "$PWD":/w -w /w alpine:3.20 sh tests/ra-goodbye-test.sh(inffbs-mesh-vpn-parker): all checks PASS, exit 0.docker run --rm --privileged -v "$PWD":/w alpine:3.20 sh -c 'apk add -q dnsmasq iproute2 python3 && sh /w/tests/dhcp-authoritative-test.sh': all checks ok, exit 0.Not tested: no test on a Gluon node. Not necessary, because only comment lines in test scripts change.