Skip to content

gluon-mesh-babel: implement neighbour check #2297

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
AiyionPrime merged 2 commits into from
Dec 14, 2022
Merged

gluon-mesh-babel: implement neighbour check #2297

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9c197da
gluon-mesh-babel: implement neighbour check
AiyionPrime Aug 13, 2021
6b6a091
fixup! gluon-mesh-babel: implement neighbour check
AiyionPrime Jan 14, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions package/gluon-mesh-babel/files/lib/gluon/state/check.d/has_neighbours
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
#!/bin/sh
out=$(echo dump | nc ::1 33123 | grep "add neighbour" 2>/dev/null) && [ -n "$out" ]

@neocturne neocturne Aug 13, 2021

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
out=$(echo dump | nc ::1 33123 | grep "add neighbour" 2>/dev/null) && [ -n "$out" ]
echo dump | nc ::1 33123 | grep -qF 'add neighbour'

As we're only interested whether there is matching output or not, grep -q should be used. Adding -F makes it more efficient, as it doesn't interpret the pattern as a regex.

@AiyionPrime AiyionPrime Jan 14, 2022 •
edited
Loading

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I still lack a node/network to test this on;
One possible issue I see are possible error-messages of nc.
I'll apply the commit in a moment. Afterwords this can be marked as blocked by #2353 .