Cannot toggle window floating

[philippkosarev]

It seems that after #484 the window-toggle-float and window-toggle-always-float shortcuts don't work anymore. Not sure if this is an issue on just my machine or not.

System details

Shell: GNOME Shell 49.1
Distro: Fedora 42 Workstation
Monitor: 2560x1440@75hz

[hesslau]

Can confirm. Tiling doesn't work at all because I can't get out of the always-float mode. Any clue if this can be changed on file somewhere?

edit: I was able to get out of the always-float mode by doing

dconf dump /org/gnome/shell/extensions/forge/ > forge.dconf
// remove line "workspace-skip-tile='0'" from forge.dconf
dconf reset -f /org/gnome/shell/extensions/forge/
dconf load /org/gnome/shell/extensions/forge/ < forge.dconf

[hesslau]

@philippkosarev lol, it just occured to me that we might just have had our workspaces set to be non-tiling. might check your settings for that

[philippkosarev]

@philippkosarev lol, it just occured to me that we might just have had our workspaces set to be non-tiling. might check your settings for that

I don't have any non-tiling workspaces. My issue is that I cannot toggle the floating mode on any windows, no matter whether they are floating or tiled.

[crimist]

Experiencing the same issue. The super+c / super+shift+c commands don't do anything at all. Reverting just #484 on master fixes the issue for me.

• Arch
• mutter 49.1-2
• gnome-shell 1:49.1-2
• Dual monitor layout

dconf dump

[/]
auto-split-enabled=true
css-last-update=uint32 37
css-updated='1659861587767'
float-always-on-top-enabled=false
focus-border-toggle=true
focus-on-hover-enabled=false
move-pointer-focus-enabled=false
showtab-decoration-enabled=true
tiling-mode-enabled=true
window-gap-hidden-on-single=true
window-gap-size=uint32 2
window-gap-size-increment=uint32 1
window-overrides-reload-trigger=uint32 1763933420
workspace-skip-tile='9'

[keybindings]
con-split-horizontal=['<Super>z']
con-split-layout-toggle=['<Super>g']
con-split-vertical=['<Super>v']
con-stacked-layout-toggle=['<Shift><Super>s']
con-tabbed-layout-toggle=['<Shift><Super>t']
con-tabbed-showtab-decoration-toggle=['<Control><Alt>y']
focus-border-toggle=['<Super>x']
prefs-open=@as []
prefs-tiling-toggle=@as []
window-focus-down=['<Super>j']
window-focus-left=['<Super>h']
window-focus-right=['<Super>l']
window-focus-up=['<Super>k']
window-gap-size-decrease=['<Control><Super>minus']
window-gap-size-increase=['<Control><Super>plus']
window-move-down=['<Shift><Super>j']
window-move-left=['<Shift><Super>h']
window-move-right=['<Shift><Super>l']
window-move-up=['<Shift><Super>k']
window-resize-bottom-decrease=['<Shift><Control><Super>i']
window-resize-bottom-increase=['<Control><Super>u']
window-resize-left-decrease=['<Shift><Control><Super>o']
window-resize-left-increase=['<Control><Super>y']
window-resize-right-decrease=['<Shift><Control><Super>y']
window-resize-right-increase=['<Control><Super>o']
window-resize-top-decrease=['<Shift><Control><Super>u']
window-resize-top-increase=['<Control><Super>i']
window-snap-center=['<Control><Alt>c']
window-snap-one-third-left=['<Control><Alt>d']
window-snap-one-third-right=['<Control><Alt>g']
window-snap-two-third-left=['<Control><Alt>e']
window-snap-two-third-right=['<Control><Alt>t']
window-swap-down=['<Control><Super>j']
window-swap-last-active=['<Super>Return']
window-swap-left=['<Control><Super>h']
window-swap-right=['<Control><Super>l']
window-swap-up=['<Control><Super>k']
window-toggle-always-float=['<Shift><Super>c']
window-toggle-float=['<Super>c']
workspace-active-tile-toggle=['<Shift><Super>w']

[crimist]

I was able to get an LLM to generate a patch that fixes the issue. If someone with more knowledge of the repo would like to formalize the patch that'd be ideal. Otherwise I'll clean it up and open a PR at some point.

The bug was introduced in commit 8ad9c9b (PR 484) when refactoring to fix
dangling pointers. The refactoring changed addFloatOverride() and
removeFloatOverride() to work with fresh data from ConfigManager via
currentProps, but forgot to update the local this.windowProps cache.

This caused toggleFloatingMode() to fail because:
1. First toggle: addFloatOverride() saves to config but doesn't update cache
2. isFloatingExempt() still reads from old cache, doesn't see the new override
3. Second toggle: thinks window is still not floating, tries to add again
4. addFloatOverride() sees duplicate in fresh config data and returns early
5. No visual change occurs because the window state never actually toggles

The fix updates this.windowProps after modifying overrides in both
addFloatOverride() and removeFloatOverride() to keep the cache in sync.

Additionally, the early return check in addFloatOverride() was too aggressive
and would prevent adding wmId overrides for different windows of the same class.
The fix now properly checks wmId when withWmId is true, allowing multiple
windows of the same class to have individual wmId overrides.

Fixes: Super+C and Super+Shift+C shortcuts now properly toggle and persist
       floating window state as intended.

Co-Authored-By: Claude <noreply@anthropic.com>
---
 lib/extension/window.js | 15 +++++++++++++--
 1 file changed, 13 insertions(+), 2 deletions(-)

diff --git a/lib/extension/window.js b/lib/extension/window.js
index 0126f16..77dd50b 100644
--- a/lib/extension/window.js
+++ b/lib/extension/window.js
@@ -103,8 +103,15 @@ export class WindowManager extends GObject.Object {
     let wmId = metaWindow.get_id();

     for (let override of overrides) {
-      // if the window is already floating
-      if (override.wmClass === wmClass && override.mode === "float" && !override.wmTitle) return;
+      // if this exact override already exists, don't add it again
+      if (override.wmClass === wmClass && override.mode === "float" && !override.wmTitle) {
+        // For wmId overrides, only return early if the wmId matches (same window instance)
+        // For class overrides, return early if any class override exists
+        if (withWmId && override.wmId !== wmId) {
+          continue; // Different window instance, keep checking
+        }
+        return; // Duplicate found, don't add
+      }
     }
     overrides.push({
       wmClass: wmClass,
@@ -115,6 +122,8 @@ export class WindowManager extends GObject.Object {
     // Save the updated overrides back to the ConfigManager
     currentProps.overrides = overrides;
     this.ext.configMgr.windowProps = currentProps;
+    // Update the local cache so isFloatingExempt sees the new override
+    this.windowProps = currentProps;
   }

   removeFloatOverride(metaWindow, withWmId) {
@@ -135,6 +144,8 @@ export class WindowManager extends GObject.Object {
     // Save the updated overrides back to the ConfigManager
     currentProps.overrides = overrides;
     this.ext.configMgr.windowProps = currentProps;
+    // Update the local cache so isFloatingExempt sees the change
+    this.windowProps = currentProps;
   }

   toggleFloatingMode(action, metaWindow) {

[lypanov]

In my case windows are being randomly floated, alas time to try a different extension / solution, I'd hoped Forge would be the one but really don't feel like having to maintain my own personal fork.

[crimist]

Opened PR with patch #496