STCOM-1533 Improve performance on pane resizing. - #2581
Draft
JohnC-80 wants to merge 3 commits into
Draft
Conversation
Bigtest Unit Test Results 1 files ±0 1 suites ±0 24s ⏱️ -1s Results for commit b3f7088. ± Comparison against base commit 9f214e6. This pull request removes 1637 and adds 1637 tests. Note that renamed tests count towards both.This pull request removes 8 skipped tests and adds 8 skipped tests. Note that renamed tests count towards both.♻️ This comment has been updated with latest results. |
|
zburke
reviewed
Aug 14, 2026
Comment on lines
+216
to
+218
| if (!pos || !pos.render) return null; | ||
| return ( | ||
| <PaneResizeHandle |
Member
There was a problem hiding this comment.
Maybe a stronger way to write this is to check for the conditions you need, else return null?
if (pos?.render) { return <PaneResizeHandle ...> }
return null;
or
return (pos?.render) ? <PaneResizeHandle ...> : null;
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Data-heavy, component-heavy views can cause some pane-resizing jank. This PR works to help Paneset's end of the deal and not add more jank due to its implementation.
Draft for now with the end of the Spike. Ready after a bit more sleuthing for jank-culprits.
So far:
<Paneset>'ssetStyleto a noop - it's only there to fulfill Paneset's own expectation when treating a nested Paneset. This avoidsgetBoundingClientRect.