STCOM-1544 - Dark/disappearing button text in the active state. - #2579
Open
JohnC-80 wants to merge 4 commits into
Open
STCOM-1544 - Dark/disappearing button text in the active state.#2579JohnC-80 wants to merge 4 commits into
JohnC-80 wants to merge 4 commits into
Conversation
zburke
approved these changes
Aug 14, 2026
zburke
left a comment
zburke
left a comment
Member
There was a problem hiding this comment.
❤️ This is nice polish. Thank you.
This is so pedantic I cannot believe I'm actually mentioning it, but the CHANGELOG doesn't mention the actual fix, which was to supply a missing/sufficiently specific style in Button.css. The other changes merely replace a hard-coded value with a reference to the same value, now stored in a variable.
Clarify the description for the color variable addition in CHANGELOG.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
STCOM-1544
Purpose
This blemish has been a peeve for a while. A better focus on our CSS variables brought this to light, so pushing this fix.
Before
After