STCOM-1469 <PaneCloseLink> - add a new closeButtonRef prop to provide a ref for the pane close icon button. - #2515
Open
BogdanDenis wants to merge 2 commits into
Open
STCOM-1469 <PaneCloseLink> - add a new closeButtonRef prop to provide a ref for the pane close icon button.#2515BogdanDenis wants to merge 2 commits into
<PaneCloseLink> - add a new closeButtonRef prop to provide a ref for the pane close icon button.#2515BogdanDenis wants to merge 2 commits into
Conversation
…vide a ref for the pane close icon button.
|
zburke
approved these changes
Dec 9, 2025
zburke
left a comment
zburke
left a comment
Member
There was a problem hiding this comment.
@BogdanDenis, LGTM, but I also don't understand where the expectations about focus expressed in the ticket come from. I'm not against merging this since it allows things to be changed but doesn't actually change them, but we may want to wait until the comments on this story are fully-resolved. Your call.
Dmitriy-Litvinenko
approved these changes
Dec 10, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
autoFocusattribute works consistently on page load, but when a component is mounted when data is loaded - it can sometimes not work. A more consistent way to focus an element is by calling afocusfunction on the element directly.For this,
<PaneCloseLink>should accept a ref prop to provide access to the button element.Issues
STCOM-1461