Skip to content

STCOM-827 Pagination Component - #1543

Draft
JohnC-80 wants to merge 16 commits into
mainfrom
stcom-827-pagination-component
Draft

STCOM-827 Pagination Component#1543
JohnC-80 wants to merge 16 commits into
mainfrom
stcom-827-pagination-component

Conversation

@JohnC-80

Copy link
Copy Markdown
Contributor

Add pagination component.

Filling a gap in our current component offerings. Most grids within FOLIO rely on infinite scroll or some other means - but doesn't hurt to have another option to fulfill app requirements.

image

@folio-org folio-org deleted a comment from id-jenkins Apr 16, 2021
Comment thread lib/Pagination/Pagination.js Outdated
Comment thread lib/Pagination/tests/interactor.js Outdated

@mkuklis mkuklis left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work @JohnC-80 👏

@sonarqubecloud

Copy link
Copy Markdown

Comment thread lib/Pagination/readme.md Outdated
Co-authored-by: Viktor Soroka <viktor_soroka@epam.com>
@BogdanDenis

Copy link
Copy Markdown
Contributor

Looks great! We're thinking of applying this component in eHoldings app, is there something that's blocking this PR from being merged?

@github-actions

github-actions Bot commented Sep 13, 2021

Copy link
Copy Markdown

Jest Unit Test Statistics

0 tests  ±0   0 ✔️ ±0   0s ⏱️ ±0s
0 suites ±0   0 💤 ±0 
0 files   ±0   0 ±0 

Results for commit a46bbb9. ± Comparison against base commit 25ec9e1.

♻️ This comment has been updated with latest results.

@github-actions

github-actions Bot commented Sep 13, 2021

Copy link
Copy Markdown

BigTest Unit Test Statistics

       1 files  ±0         1 suites  ±0   5s ⏱️ ±0s
1 302 tests +6  1 296 ✔️ +6  6 💤 ±0  0 ±0 
1 305 runs  +6  1 299 ✔️ +6  6 💤 ±0  0 ±0 

Results for commit a46bbb9. ± Comparison against base commit 25ec9e1.

♻️ This comment has been updated with latest results.

@sonarqubecloud

Copy link
Copy Markdown

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

@sonarqubecloud

sonarqubecloud Bot commented Jan 6, 2022

Copy link
Copy Markdown

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

@sonarqubecloud

sonarqubecloud Bot commented Jan 6, 2022

Copy link
Copy Markdown

Please retry analysis of this Pull-Request directly on SonarCloud.

@zburke

zburke commented Jan 7, 2022

Copy link
Copy Markdown
Member

@JohnC-80, this PR has been hanging out for a while. Can we either merge it, close it, or move it to draft?

@sonarqubecloud

sonarqubecloud Bot commented Jun 8, 2022

Copy link
Copy Markdown

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

@JohnC-80
JohnC-80 marked this pull request as draft January 23, 2023 17:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants