test: Fix unstable test with wrong assertions - #1395
Merged
Conversation
|
Aliaksandr-Fedasiuk
approved these changes
Jul 29, 2026
psmagin
approved these changes
Jul 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Purpose
Fix unstable test with wrong assertions.
Test body suggests that item should be updated but assertion verifies that there was only 1 create event and it's unstable because there's no wait so sometimes it wrongly passes when update event is not captured for the time of the assertion.
x-okapi-url headers are inconsistent across integration tests, sometimes vertx url is used, sometimes - wiremock url.
Approach
Rework assertion to wait for the update event.
Use wiremock url when appllicable for http client, kafka assertion, use vertx url otherwise
Changes Checklist