Skip to content

test: Fix unstable test with wrong assertions - #1395

Merged
viacheslavkol merged 6 commits into
masterfrom
fix-test
Jul 29, 2026
Merged

test: Fix unstable test with wrong assertions#1395
viacheslavkol merged 6 commits into
masterfrom
fix-test

Conversation

@viacheslavkol

@viacheslavkol viacheslavkol commented Jul 24, 2026

Copy link
Copy Markdown
Contributor

Purpose

Fix unstable test with wrong assertions.
Test body suggests that item should be updated but assertion verifies that there was only 1 create event and it's unstable because there's no wait so sometimes it wrongly passes when update event is not captured for the time of the assertion.
x-okapi-url headers are inconsistent across integration tests, sometimes vertx url is used, sometimes - wiremock url.

Approach

Rework assertion to wait for the update event.
Use wiremock url when appllicable for http client, kafka assertion, use vertx url otherwise

Changes Checklist

  • API Changes: Document any API paths, methods, request or response bodies changed, added, or removed.
  • Database Schema Changes: Indicate any database schema changes and their impact. Confirm that migration scripts were created.
  • Interface Version Changes: Indicate any changes to interface versions.
  • Interface Dependencies: Document added or removed dependencies.
  • Permissions: Document any changes to permissions.
  • Logging: Confirm that logging is appropriately handled.
  • Unit Testing: Confirm that changed classes were covered by unit tests.
  • Integration Testing: Confirm that changed logic was covered by integration tests.
  • Manual Testing: Confirm that changes were tested on local or dev environment.
  • NEWS: Confirm that the NEWS file is updated with relevant information about the changes made in this pull request.

@viacheslavkol viacheslavkol self-assigned this Jul 24, 2026
@sonarqubecloud

Copy link
Copy Markdown

@viacheslavkol
viacheslavkol marked this pull request as ready for review July 29, 2026 11:35
@viacheslavkol
viacheslavkol requested a review from a team as a code owner July 29, 2026 11:35
@viacheslavkol
viacheslavkol merged commit 95d798f into master Jul 29, 2026
20 checks passed
@viacheslavkol
viacheslavkol deleted the fix-test branch July 29, 2026 12:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants