-
Notifications
You must be signed in to change notification settings - Fork 1
Solubility usability prediction NetSolP #78
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
29cdf6e
feat: solubility and usability prediction by NetSolP
fmoorhof 3ca1c1a
style: stick closer to netsolp synthax for easier integration
fmoorhof 8810522
feat: integration of solubility prediction into the app workflow
fmoorhof 7482b8f
fix: export of multiple same named column names break execution.
fmoorhof 6b16366
op: potential bug: deployment and run without installation of additio…
fmoorhof c7723b1
issue (bug_risk): Use the configured MODELS_PATH instead of a hard-co…
fmoorhof File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -37,16 +37,29 @@ docker start CONTAINERID | |
| docker exec -it CONTAINERID /bin/bash | ||
| ``` | ||
|
|
||
| ## EC number prediction with CLEAN | ||
| ## Additional predictors based on ESM1b | ||
| Note: Deployment yet untested on absence of additional predictors. Tried to import only when called but not sure if this was enough. | ||
| ### EC number prediction with CLEAN | ||
| Install CLEAN, download weights and place them into the hard coded locations. | ||
| ``` | ||
| git clone https://github.com/tttianhao/CLEAN.git | ||
| git clone https://github.com/fmoorhof/CLEAN.git | ||
| cd CLEAN/app | ||
| # get model weights (see below) | ||
| python build.py install # requires activated venv/conda | ||
|
Comment on lines
+43
to
48
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. nitpick (typo): Use standard hyphenation for "hard-coded" in both installation instructions. Please change both occurrences (in the CLEAN and NetSolP sections) from "hard coded" to "hard-coded locations" to match standard technical writing conventions. Suggested implementation: |
||
| cd ../../SelectZyme | ||
| ``` | ||
| Download, unzip [these files](https://drive.google.com/file/d/1kwYd4VtzYuMvJMWXy6Vks91DSUAOcKpZ/view?usp=sharing) and move the contents to `data/pretrained`. | ||
|
|
||
| ### Solubility prediction with NetSolP | ||
| Install NetSolP, download weights and place them into the hard coded locations. | ||
| ``` | ||
| git clone https://github.com/fmoorhof/NetSolP-1.0 | ||
| pip install -r NetSolP-1.0/PredictionServer/requirements_gpu.txt --extra-index-url https://download.pytorch.org/whl/cu126 | ||
| pip install -e NetSolP-1.0/ | ||
| wget https://services.healthtech.dtu.dk/services/NetSolP-1.0/netsolp-1.0.ALL.tar.gz | ||
| tar -xzf netsolp-1.0.ALL.tar.gz NetSolP-1.0/ | ||
| mv NetSolP-1.0/models NetSolP-1.0/PredictionServer/models | ||
| ``` | ||
|
|
||
| ## Test the install | ||
| Run some unit tests to see if SelectZyme got setup properly on your system. | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
suggestion (typo): Clarify and slightly rephrase the note about deployment being untested for better grammar.
Consider rephrasing this note for clarity and grammar, for example:
"Note: Deployment is yet untested in the absence of additional predictors. Imports are deferred until the predictors are called, but it is not yet verified that this is sufficient."