Vamr final - #1330
Open
MaxenceAnt wants to merge 150 commits into
Open
Conversation
Modification of blockContainer->getParameters(popID) to blockContainer->getParameters() The previous version caused problems when computing dt for more than one population, as this could result in extremely low values.
The adjustVelocityBlocks in the subcycle loop has been modified for acceleration. The previous version caused "bailing out at vlasovsolver/cpu_acc_map.cpp". The new version may slightly increase computational time if there are a lot of subcycles.
Update vlasovmover.cpp
Maxence ant patch 1
The way in which the velocity blocks are adjusted in the acceleration part has been modified to ensure that they are always updated for all cells in the first step. Before we were adjusting the velocity blocks only for the cells that need to be accelerated in a more than one step process (i.e. at least 2 subcycles), so that means not all the cells. And when we adjust the cells, the first step is to update its velocity block information. And then we share this information between neighbouring spatial cells. BUT if the neighbour cells are not in the cells that need to do a two step process, it is not updated, and if we have 2 species with different velocity grids, the shared value will be the one of the old species. Meaning that we share false and out of bound information.
Update vlasovmover.cpp
Merging the Vamr with vlasiator-dev
Correct the inaccurate description of vamr_criteria_method
Dcomp has been added, it takes into account the modification of the refinement criteria + more comments
Potential multipop vAMR bug in SmallRefinedOrder1 solved
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
New vamr version