testpackage addition: restart read on single(or multiple) mpi rank - #1328
Open
lassejsc wants to merge 7 commits into
Open
testpackage addition: restart read on single(or multiple) mpi rank#1328lassejsc wants to merge 7 commits into
lassejsc wants to merge 7 commits into
Conversation
Contributor
|
Single rank in itself is already a good test but I think another rank count, but parallel, would be needed, say 8 ranks if the base case is run on 16, or so. |
lassejsc
marked this pull request as ready for review
July 15, 2026 14:09
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since the restart IO depends on the number of ranks here https://github.com/fmihpc/vlasiator/blob/dev/ioread.cpp#L1422 . By default the restarts are written with the
--ntasksnumber of tasks so reading them with a single rank will use theelsepart of the code there. Not sure if this fully answers to #1163Update:
Changed
single_cellintest_definitions_small.shto berankswhich sets the number of ranks to be used when running the test. Setting this to"half"as done in the new restart read tests will used half the $SLURM_NTASK ranks (floored division)