Made it possible to launch block adjust functions on GPU with more than 65535 cells - #1300
Open
MikaelHuppunen wants to merge 3 commits into
Open
Made it possible to launch block adjust functions on GPU with more than 65535 cells#1300MikaelHuppunen wants to merge 3 commits into
MikaelHuppunen wants to merge 3 commits into
Conversation
MikaelHuppunen
marked this pull request as draft
June 11, 2026 14:53
MikaelHuppunen
marked this pull request as ready for review
June 12, 2026 08:03
markusbattarbee
requested changes
Jun 17, 2026
markusbattarbee
left a comment
markusbattarbee
left a comment
Contributor
There was a problem hiding this comment.
Two missed spots
Just for completeness, GPU ACC batching / chunking could also be checked that it won't ever try to go over this 65k limit.
Contributor
Author
|
Acc chunks shouldn't get above the limit unless allocation count does. I guess it makes sense to check that allocation count isn't over the limit. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.