Skip to content

Removing loop from build_dual_from_vertices #490

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
lassejsc wants to merge 2 commits into
base: dev
Choose a base branch
from
Open

Removing loop from build_dual_from_vertices #490

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5fd8d00
Found a trick to remove the loop, makes it slightly faster
lassejsc Jul 27, 2026
d293596
reshapes to make it work, forgor
lassejsc Jul 27, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 12 additions & 12 deletions analysator/vlsvfile/vlsvreader.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3387,7 +3387,6 @@ def build_cell_neighborhoods(self, cids):
return cell_neighbor_sets



def build_dual_from_vertices(self, vertices):

vertices = list(set(vertices))
Expand Down Expand Up @@ -3418,19 +3417,20 @@ def build_dual_from_vertices(self, vertices):
eps = 1
v_cells = np.zeros((len_todo, 8),dtype=int)
v_cellcoords = np.zeros((len_todo, 8,3))
ii = 0
vcoords = self.get_vertex_coordinates_from_indices(todo)

# TODO get rid of the loop
offsets = []
for x in [-1,1]:
for y in [-1,1]:
for z in [-1,1]:
offsets.append([x,y,z])
v_cellcoords[:,ii,:] = eps*np.array((x,y,z))[np.newaxis,:] + vcoords
v_cells[:,ii] = self.get_cellid(v_cellcoords[:,ii])
ii += 1

offsets=np.array([
[-1.,-1.,-1.],
[-1.,-1.,1.],
[-1.,1.,-1.],
[-1.,1.,1.],
[1.,-1.,-1.],
[1.,-1.,1.],
[1.,1.,-1.],
[1.,1.,1.],
])
v_cellcoords=np.swapaxes(vcoords+eps*offsets[:,np.newaxis],0,1)
v_cells=self.get_cellid(v_cellcoords.reshape((-1,3))).reshape((-1,8))
v_cellcoords = self.get_cell_coordinates(v_cells.reshape((-1))).reshape((-1,8,3))

dual_sets.update({vinds: tuple(v_cells[i,:]) for i,vinds in enumerate(todo)})
Expand Down
Loading