Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
20 commits
Select commit Hold shift + click to select a range
d7582d2
feat: add ClusterPlugin interface for shared-cluster plugins
pingsutw Jul 15, 2026
b114a81
fix: propagate task execution labels/annotations to the RayJob submit…
pingsutw Jul 16, 2026
3cac477
refactor: extract UpdateLinkReadiness for dashboard/IDE link handling
pingsutw Jul 16, 2026
9caa66c
fix: source submitter pod labels from task metadata; add StartCleanup…
pingsutw Jul 16, 2026
a73e7ab
feat: plugins set PodNamePrefix for their own pods
pingsutw Jul 16, 2026
5564191
feat: LogContext.pod_name_prefix is repeated
pingsutw Jul 16, 2026
eaae9ef
chore: restore connect mocks clobbered by buf-go
pingsutw Jul 16, 2026
0427dd2
feat: LoggingContext.pod_name_prefix is repeated
pingsutw Jul 16, 2026
055c7bb
fix: keep pod_name_prefix a string; add repeated pod_name_prefixes
pingsutw Jul 17, 2026
6a60db5
logs: deprecate scalar pod_name_prefix in favor of pod_name_prefixes
pingsutw Jul 17, 2026
8b20aa3
Merge commit '6351dc892ec54ba39f0697298a400e1cd29a29df' into feature/…
pingsutw Jul 17, 2026
9b60c5d
update proto comments
pingsutw Jul 20, 2026
10e2cc0
nit
pingsutw Jul 20, 2026
79cefe1
Apply suggestions from code review
pingsutw Jul 20, 2026
fc83037
Merge branch 'feature/cluster-plugin-interface' of https://github.com…
pingsutw Jul 20, 2026
f3375c2
make gen
pingsutw Jul 20, 2026
e0935ee
fix(ci): regenerate protobuf files for pod_name_prefixes across all l…
pingsutw Jul 20, 2026
c9cac36
nit
pingsutw Jul 20, 2026
9fdf247
rebase
pingsutw Aug 3, 2026
e3bc196
fix: regenerate gen/rust/src/flyteidl2.core.rs
pingsutw Aug 3, 2026
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions executor/pkg/plugin/registry.go
Original file line number Diff line number Diff line change
Expand Up @@ -53,6 +53,13 @@ func (r *Registry) Initialize(ctx context.Context) error {

// Load k8s plugins
for _, entry := range r.pluginRegistry.GetK8sPlugins() {
if entry.ClusterPlugin != nil {
logger.Infof(ctx, "Skipping k8s plugin %q: cluster plugin entries are not supported by the executor", entry.ID)
continue
}
if entry.Plugin == nil {
return fmt.Errorf("invalid k8s plugin entry %q: Plugin is nil", entry.ID)
}
Comment thread
pingsutw marked this conversation as resolved.
pm := executorK8s.NewPluginManager(
entry.ID,
entry.Plugin,
Expand Down
7 changes: 5 additions & 2 deletions flyteidl2/core/execution.proto
Original file line number Diff line number Diff line change
Expand Up @@ -151,8 +151,11 @@ message LogContext {
repeated PodLogContext pods = 1;
string primary_pod_name = 2;
ConnectorLogContext connector = 3;
// Pod-name prefix used by log sources to narrow stream/pod searches
string pod_name_prefix = 4;
// Deprecated: use pod_name_prefixes. Still populated with the task's own pod-name prefix for
// readers that predate pod_name_prefixes.
string pod_name_prefix = 4 [deprecated = true];
// Pod-name prefixes used by log sources to narrow stream/pod searches.
repeated string pod_name_prefixes = 5;
Comment thread
pingsutw marked this conversation as resolved.
}

// ConnectorLogContext describes how to reach a connector that owns an action's logs.
Expand Down
7 changes: 5 additions & 2 deletions flyteidl2/logs/dataplane/payload.proto
Original file line number Diff line number Diff line change
Expand Up @@ -34,8 +34,11 @@ message LoggingContext {
map<string, string> kubernetes_pod_labels = 9;
common.Sort.Direction order = 10;
uint64 number_of_batches = 11;
// +optional, Pod-name prefix used by log sources to narrow stream/pod searches.
string pod_name_prefix = 12;
// +optional. Deprecated: use pod_name_prefixes. Still populated with the task's own pod-name
// prefix for readers that predate pod_name_prefixes.
string pod_name_prefix = 12 [deprecated = true];
// +optional, pod-name prefixes used by log sources to narrow stream/pod searches.
repeated string pod_name_prefixes = 13;
Comment thread
pingsutw marked this conversation as resolved.
}

// Parameters of environment in which logs were collected. Should contain everything
Expand Down
Loading
Loading