(wip) flyte backfill <trigger> for scheduled triggers - #1383
Open
kumare3 wants to merge 1 commit into
Open
Conversation
Expands a cron or fixed-rate trigger's schedule across a window, shows exactly which runs it would create, and on approval launches a driver run that creates them from inside the cluster (so a long backfill does not depend on the client staying connected, and the work is observable and abortable like any run). De-duplication is the point of the naming. A backfilled slot is created the way the scheduler creates a real fire -- addressed by TriggerName, named by the deterministic slot hash, and marked schedule-sourced -- so a slot that already ran is recognised and skipped, and re-running the same backfill is a no-op. `--force` salts the name into a separate namespace to re-run those slots. The run-name hash mirrors the scheduler's runName() exactly: FNV-1 (not FNV-1a) 64-bit over org:project:domain:task:trigger plus unpadded wall-clock fields, rendered as unpadded hex. Expected values in tests/backfill/test_naming.py were generated by running the Go implementation; cron expansion is likewise pinned against robfig/cron v3, the parser the scheduler uses. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Expands a cron or fixed-rate trigger's schedule across a window, shows exactly which runs it would create, and on approval launches a driver run that creates them from inside the cluster (so a long backfill does not depend on the client staying connected, and the work is observable and abortable like any run).
De-duplication is the point of the naming. A backfilled slot is created the way the scheduler creates a real fire -- addressed by TriggerName, named by the deterministic slot hash, and marked schedule-sourced -- so a slot that already ran is recognised and skipped, and re-running the same backfill is a no-op.
--forcesalts the name into a separate namespace to re-run those slots.The run-name hash mirrors the scheduler's runName() exactly: FNV-1 (not FNV-1a) 64-bit over org:project:domain:task:trigger plus unpadded wall-clock fields, rendered as unpadded hex. Expected values in tests/backfill/test_naming.py were generated by running the Go implementation; cron expansion is likewise pinned against robfig/cron v3, the parser the scheduler uses.