Skip to content

Add specs for ControlFlow/? etc. - #1723

Merged
ranjitjhala merged 3 commits into
mainfrom
control-flow-specs
Aug 14, 2026
Merged

Add specs for ControlFlow/? etc.#1723
ranjitjhala merged 3 commits into
mainfrom
control-flow-specs

Conversation

@ranjitjhala

Copy link
Copy Markdown
Contributor

No description provided.

@nilehmann nilehmann left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but in what situation do you know a Result is an error (or ok) and use ? on it?

Comment thread tests/tests/with_deps/neg/extern_specs/flux_core_ptr_cast00.rs
@ranjitjhala

Copy link
Copy Markdown
Contributor Author

LGTM, but in what situation do you know a Result is an error (or ok) and use ? on it?

Indeed -- but with this thicket of break and continue its hard to tease apart what exactly is required.

Are you saying some of the tests are redundant?

@ranjitjhala

Copy link
Copy Markdown
Contributor Author

(CC added them, but they looked reasonable...)

@nilehmann

Copy link
Copy Markdown
Member

I'm wondering what prompted this. Is there some specific code that was failing that requires these specs?

@ranjitjhala

Copy link
Copy Markdown
Contributor Author

@ranjitjhala

Copy link
Copy Markdown
Contributor Author

Have to say its quite neat how all the bits snap together nicely to make this work. Shocking!

@nilehmann

Copy link
Copy Markdown
Member

Ah interesting. Perhaps worth adding something like that as a test

Comment thread tests/tests/with_deps/pos/extern_specs/control_flow00.rs
@ranjitjhala
ranjitjhala merged commit 337844e into main Aug 14, 2026
10 checks passed
@ranjitjhala
ranjitjhala deleted the control-flow-specs branch August 14, 2026 23:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants