Add specs for ControlFlow/? etc. - #1723
Merged
Merged
Conversation
nilehmann
approved these changes
Aug 14, 2026
nilehmann
left a comment
Member
There was a problem hiding this comment.
LGTM, but in what situation do you know a Result is an error (or ok) and use ? on it?
Contributor
Author
Indeed -- but with this thicket of break and continue its hard to tease apart what exactly is required. Are you saying some of the tests are redundant? |
Contributor
Author
|
(CC added them, but they looked reasonable...) |
Member
|
I'm wondering what prompted this. Is there some specific code that was failing that requires these specs? |
Contributor
Author
|
Have to say its quite neat how all the bits snap together nicely to make this work. Shocking! |
Member
|
Ah interesting. Perhaps worth adding something like that as a test |
ranjitjhala
commented
Aug 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.