ci(device_info_plus): fix macOS/iOS example build with Swift Package Manager - #3985
Merged
Merged
Conversation
…Manager Remove leftover CocoaPods integration from the example Xcode projects. Without a Podfile, CI never runs pod install, so the [CP] build phases fail on missing Pods-Runner xcfilelists. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The device_info_plus example app no longer has a Podfile after the move to Swift Package Manager, but its Xcode project(s) still contain the CocoaPods integration:
[CP] Check Pods Manifest.lock/[CP] Embed Pods Frameworksbuild phases,Pods_Runner.frameworklinks andPods-*.xcconfigbase configurations.On CI (clean checkout, no Podfile) Flutter only adds SPM integration and never runs
pod install, so the build fails with:Locally it only works if an ignored
Podfile/Pods/from before the migration is still around.This PR removes the CocoaPods integration from the example project(s) (the same cleanup as #3938 did for connectivity_plus) and commits the SPM integration and project migrations Flutter applies on build. Verified with a clean
flutter build ios --simulatorandflutter build macoswithout any Podfile.Related Issues
Checklist
CHANGELOG.mdnor the plugin version inpubspec.yamlfiles.flutter analyze) does not report any problems on my PR.Breaking Change
!in the title as explained in Conventional Commits).🤖 Generated with Claude Code