feat: YouTube-style chapters on the progress bar - #959
Open
Ortes wants to merge 4 commits into
Open
Conversation
- ChewieChapter model ({title, start}) exposed on ChewieController.chapters
- Progress bar (background/buffered/played) is drawn split at chapter
boundaries with a 2px gap, YouTube-style
- Hovering (desktop) or scrubbing the bar shows the pointed chapter title
and time in a label above the bar
- Empty chapters list keeps the previous rendering unchanged
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #959 +/- ##
==========================================
+ Coverage 43.82% 53.36% +9.54%
==========================================
Files 21 22 +1
Lines 1602 1666 +64
==========================================
+ Hits 702 889 +187
+ Misses 900 777 -123 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Ortes
marked this pull request as draft
August 6, 2026 13:17
Ortes
marked this pull request as ready for review
August 6, 2026 13:18
Ortes
force-pushed
the
feat/progress-bar-chapters-upstream
branch
from
August 6, 2026 13:33
3f99788 to
6ad6909
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adds an optional
chapterslist toChewieController(ChewieChapter { title, start }). When provided, the progress bar is drawn split into chapter segments with a small 2px gap at each chapter boundary — the YouTube-style chaptered timeline — and hovering or scrubbing the bar shows a floating pill with the pointed chapter's title next to the timecode.All three control skins (Material, MaterialDesktop, Cupertino) get the segmented rendering, since they all funnel into the shared
VideoProgressBar/_ProgressBarPainter.Behaviour
chaptersdefaults to an empty list: the painter and widget tree are exactly as before, so existing apps are unaffected.(0, duration)are ignored defensively.Notes
The hover pill here shares its look with the hover-time indicator proposed in #956 — if both land, they compose naturally (title + timecode in one label). The click cursor on the bar is handled separately in #950.