[Linter]: Support for deprecated arguments by gigalasr · Pull Request #2630 · flowr-analysis/flowr

gigalasr · 2026-07-09T15:41:00Z

TODO:

Support for ifValue for args
Support version constraint
Support for Identifiers with package name

gigalasr · 2026-07-09T16:31:29Z

Questions:

Should the linter rule return the node id and source range of the entire function, or just of the deprecated arg?
How can I make this work with the new identifiers that are prefixed with the package name?

EagleoutIce · 2026-07-09T16:34:00Z

1. Should the linter rule return the node id and source range of the entire function, or just of the deprecated arg?

Just for the argument please

2. How can I make this work with the new identifiers that are prefixed with the package name?

unsure what you mean here because the argument names cannot be namespaced? Could you please elaborate with an example?

gigalasr · 2026-07-09T16:37:32Z

Oki, thank you!
In line 76 (https://github.com/flowr-analysis/flowr/pull/2630/changes#diff-08ba3901670b25d88a746877af089e407a93f5ec8a0b09db4b1bf47e1eb71c4aR76) I use the target from the CallTargetsEnrichment to index the whenArgs record. However, target can have names like deply:someFn, but the whenArgs record (currently) only contains names like someFn.

EagleoutIce · 2026-07-09T16:39:05Z

Aah okay so you can use either Identifier::toQualified or also Identifier::matches (or match? not sure rn) to bridge the gap - is this what you needed?

gigalasr · 2026-07-09T16:39:47Z

Sounds like it, I will try that! Thank you!

…support

EagleoutIce · 2026-08-08T16:53:52Z

+	hardcoded: number
+}
+
+const AlwaysDeprecated = [


can we map these to the built in call props

EagleoutIce · 2026-08-08T16:55:38Z

+	'all_equal', 'arrange_all', 'distinct_all', 'filter_all', 'group_by_all', 'summarise_all', 'mutate_all', 'select_all', 'vars', 'all_vars', 'id', 'failwith', 'select_vars', 'rename_vars', 'select_var', 'current_vars', 'bench_tbls', 'compare_tbls', 'compare_tbls2', 'eval_tbls', 'eval_tbls2', 'location', 'changes', 'combine', 'do', 'funs', 'add_count_', 'add_tally_', 'arrange1_', 'count_', 'distinct_', 'do_', 'filter_', 'funs_', 'group_by_', 'group_indices_', 'mutate_', 'tally_', 'transmute_', 'rename_', 'rename_vars_', 'select_', 'select_vars_', 'slice_', 'summarise_', 'summarize_', 'summarise_each', 'src_local', 'tbl_df', 'add_rownames', 'group_nest', 'group_split', 'with_groups', 'nest_by', 'progress_estimated', 'recode', 'sample_n', 'top_n', 'transmute', 'fct_explicit_na', 'aes_', 'aes_auto', 'annotation_logticks', 'is.Coord', 'coord_flip', 'coord_map', 'is.facet', 'fortify', 'is.ggproto', 'guide_train', 'is.ggplot', 'qplot', 'is.theme', 'gg_dep', 'liply', 'isplit2', 'list_along', 'cross', 'invoke', 'at_depth', 'prepend', 'rerun', 'splice', '`%@%`', 'rbernoulli', 'rdunif', 'when', 'update_list', 'map_raw', 'accumulate', 'reduce_right', 'flatten', 'map_dfr', 'as_vector', 'transpose', 'melt_delim', 'melt_fwf', 'melt_table', 'read_table2', 'str_interp', 'as_tibble', 'data_frame', 'tibble_', 'data_frame_', 'lst_', 'as_data_frame', 'as.tibble', 'frame_data', 'trunc_mat', 'is.tibble', 'tidy_names', 'set_tidy_names', 'repair_names', 'extract_numeric', 'complete_', 'drop_na_', 'expand_', 'crossing_', 'nesting_', 'extract_', 'fill_', 'gather_', 'nest_', 'separate_rows_', 'separate_', 'spread_', 'unite_', 'unnest_', 'extract', 'gather', 'nest_legacy', 'separate_rows', 'separate', 'spread'
+];
+
+const ConditionallyDeprecated = {


nice as an example :) maybe reference the deprecation notice/url?

EagleoutIce · 2026-08-08T16:59:26Z

+export interface DeprecatedArgumentResult extends DeprecatedFunctionResultBase {
+	readonly type: 'deprecated-argument'
+	/** The name or index of the deprecated argument */
+	readonly arg:  string | number


this does not make it clear what this will contain. like why allow both? every parameter has a name so there should be one. is this automatically a name if it was given named and index if unnamed?

EagleoutIce · 2026-08-08T17:00:57Z

+	/** A better alternative is available, and the function is marked for removal {@link https://lifecycle.r-lib.org/articles/stages.html#deprecated} */
+	Deprecated = 'deprecated',
+	/** No longer works and is removed and replaced by another function {@link https://www.rdocumentation.org/packages/base/versions/3.6.2/topics/Defunct} */
+	Defunct = 'defunct'


is defunct associated with exceptions? if so we could pipe this into flowR's exception handling

EagleoutIce · 2026-08-08T17:01:29Z

+}
+
+interface Metadata extends MergeableRecord {
+	sigdb:     number,


does this code the number of hits from the sigdb, the number of entries in the sigdb.... this should be made clearer

EagleoutIce · 2026-08-08T17:07:06Z

+ */
+async function deprecateFunctionConditionally(candidate: PotentialFunction, dataflow: DataflowGraph, idMap: AstIdMap, analyzer: ReadonlyFlowrAnalysisProvider<KnownParser>, info: DeprecatedFunctionInformation): Promise<DeprecatedFunctionRuleResult[]> {
+	const results: DeprecatedFunctionRuleResult[] = [];
+	const result = await analyzer.query([{


uuuh this is a performance hazard. check whether you need to do this first, then do it once and take the info. even if you guess just one package this has to solve a big system.

EagleoutIce · 2026-08-08T17:08:41Z

+			const name = candidate.target.includes('::') ? Identifier.getName(Identifier.parse(candidate.target)) : candidate.target;
+			const info = config.conditionally[name];
+			if(isNotUndefined(info)) {
+				// Check functions from DeprecatedFunctionsConfig.conditionally


any reasons for these comments?

EagleoutIce · 2026-08-08T17:09:02Z


+		// 2. Uses hardcoded information about deprecated arguments and deprecated functions
+		const results: DeprecatedFunctionRuleResult[] = (await Promise.all(detectedFunctions.map(async candidate => {
+			const name = candidate.target.includes('::') ? Identifier.getName(Identifier.parse(candidate.target)) : candidate.target;


why even check for :: Identifier shuold be doing this just fine! I nmean its technically fine as a safe guard but this could go south

EagleoutIce · 2026-08-08T17:09:21Z

+
+	// Deprecated Argument: If `whenArgs` is provided, only mark deprecated arguments
+	if(info.whenArgs) {
+		const vertex = dataflow.getVertex(candidate.node.info.id);


could we please structure this into helper functions? :D

EagleoutIce · 2026-08-08T17:09:49Z

+/**
+ * Test if a function call has an argument with a specific value
+ */
+export function hasArgumentValue(


this could be.. should be moved in to the Rargument helper object i think

gigalasr added 2 commits July 9, 2026 15:17

feat(lint): add structure for deprectaed args - #1870

c097974

feat(lint): only detect when deprectaed arg is present - #1870

9116b6e

gigalasr self-assigned this Jul 9, 2026

gigalasr commented Jul 9, 2026

View reviewed changes

Comment thread src/linter/rules/deprecated-functions.ts Outdated

gigalasr added 4 commits July 10, 2026 12:06

feat(lint): allow new metadata in functions as well - #1870

05e92b8

feat(lint): pretty print new deprecation info - #1870

a43d0bc

feat(lint): use source location of arg - #1870

493606b

Merge remote-tracking branch 'origin/main' into 1870-deprecated-args-…

5efa7cc

…support

EagleoutIce reviewed Jul 14, 2026

View reviewed changes

gigalasr added 3 commits July 16, 2026 11:18

Merge remote-tracking branch 'origin/main' into 1870-deprecated-args-…

e59b179

…support

feat-fix(lint): use new RRange util - #1870

b4a79ba

docs(eval): describe interface and deprecation state - #1870

ae5965b

EagleoutIce force-pushed the main branch from 46b19e0 to f86edae Compare July 17, 2026 11:08

gigalasr added 6 commits July 23, 2026 10:58

feat(dep): cleaner config - #1870

314adc7

Merge remote-tracking branch 'origin/main' into 1870-deprecated-args-…

1172cd3

…support

feat(dep): support for version checking - #1870

2c89bc7

Merge remote-tracking branch 'origin/main' into 1870-deprecated-args-…

118a07d

…support

feat(dep): version check for functions #1870

6f0049e

feat(lint): ifValue support for deprecated args - #1870

e36782b

EagleoutIce force-pushed the main branch 2 times, most recently from db3f78d to e515c3b Compare August 1, 2026 08:46

gigalasr added 4 commits August 6, 2026 18:00

Merge remote-tracking branch 'origin/main' into 1870-deprecated-args-…

7a80a2a

…support

lint(linter): eslint fixes - #1870

6bb30fc

feat(lint): use identifier - #1870

fa811e5

feat(lint): try to fix derrived range - #1870

ae6c74f

gigalasr added 3 commits August 7, 2026 14:16

Merge remote-tracking branch 'origin/main' into 1870-deprecated-args-…

f69a89b

…support

feat(depr): use guess-dep querry - #1870

8d9cbfd

Merge remote-tracking branch 'origin/main' into 1870-deprecated-args-…

f05e5e0

…support

gigalasr marked this pull request as ready for review August 7, 2026 15:37

gigalasr requested a review from EagleoutIce August 7, 2026 15:37

EagleoutIce reviewed Aug 8, 2026

View reviewed changes

Uh oh!

Conversation

gigalasr commented Jul 9, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

gigalasr commented Jul 9, 2026

Uh oh!

EagleoutIce commented Jul 9, 2026

Uh oh!

gigalasr commented Jul 9, 2026

Uh oh!

EagleoutIce commented Jul 9, 2026

Uh oh!

gigalasr commented Jul 9, 2026

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

gigalasr commented Jul 9, 2026 •

edited

Loading