Repository navigation
feat(flow-php/parquet): both engines cap row groups by rows and write the same footer - #2717
Merged
Merged
Conversation
… the same footer - new ROW_GROUP_MAXIMUM_ROWS_COUNT option, honoured exactly by both engines - arrow engine writes Flow's created_by and no ARROW:schema key - arrow reader no longer caches a whole row group of filter columns - from_sequence_number() streams integer sequences - extension ABIs back to 2, one bump since 0.46.0
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## 1.x #2717 +/- ##
============================================
+ Coverage 87.00% 90.50% +3.49%
- Complexity 2230 31055 +28825
============================================
Files 2197 2178 -19
Lines 93874 89818 -4056
============================================
- Hits 81679 81286 -393
+ Misses 12195 8532 -3663
🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves: #xxx
Change Log
Added
flow-php/parquet-Option::ROW_GROUP_MAXIMUM_ROWS_COUNTcaps row groups by rows on both enginesFixed
flow-php/parquet- arrow engine writes Flow'screated_byand noARROW:schemakey, like the PHP engineflow-php/arrow-ext- filtered reads no longer hold a whole row group of decoded filter columns in memoryflow-php/etl-from_sequence_number()no longer builds the whole integer sequence in memoryChanged
flow-php/arrow-ext-FLOW_ARROW_ABIis 2, one bump since 0.46.0flow-php/flow-php-ext-FLOW_PHP_ABIis 2, one bump since 0.46.0Removed
Deprecated
Security