kola/misc: modernize root-on-raid to use Butane - #929
Open
amanmaurya92 wants to merge 1 commit into
Open
Conversation
This resolves an ancient TODO by switching the ignition configuration to use Butane (Ignition v3). Modern Ignition supports 'wipe_partition_entry: true', which allows us to manipulate partition 9 directly on the primary boot disk. This completely removes the previous requirement for a secondary virtual disk and unlocks the RAID root test to run natively on all cloud platforms, rather than just qemu. Signed-off-by: amanmaurya92 <amanmaurya9209@gmail.com>
amanmaurya92
force-pushed
the
fix/raid-ignition
branch
from
August 21, 2026 04:32
ccb9985 to
fba02df
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This resolves an ancient
TODOby migrating thecl.disk.raid*.rootignition configuration from legacy JSON to a modern Butane payload.Modern Ignition supports
wipe_partition_entry: true, which allows us to selectively zero out partition 9 directly on the primary boot disk and replace it with partitions 9 and 10 for the RAID array. Because of this upgrade, we have completely removed the artificial requirement for a secondary virtual disk and unlocked the RAID root test to run natively on all cloud platforms, rather than justqemu.How to use
Reviewers can validate this PR by running the modified Kola test and confirming that the nodes successfully boot with root on RAID natively across different platforms:
Testing done
Executed
$env:GOOS="linux"; cd kola/tests/misc; go buildto syntactically verify the package logic and ensure no compilation regressions occurred. We also wrote a scratch script to runconf.Butane()locally, proving that the YAML parser natively parses and correctly translates thewipe_partition_entry: truepayload into valid Ignition v3 JSON!changelog/directory (user-facing change, bug fix, security fix, update)/bootand/usrsize, packages, list files for any missing binaries, kernel modules, config files, kernel modules, etc.