Update gophercloud to v2 - #928
Closed
imshubham22apr-gif wants to merge 1 commit into
Closed
Conversation
Signed-off-by: Aashish Pandit <imshubham.22apr@gmail.com>
imshubham22apr-gif
force-pushed
the
issue-1667
branch
from
August 20, 2026 10:42
a6cdb6a to
a82efbf
Compare
Contributor
|
I'll have to close this PR in favor of: #897 - this is clearly a duplicate. @imshubham22apr-gif in open-source, you usually check if someone is already working on a an issue (flatcar/Flatcar#1667 (comment)). If you want to contribute on this specific topic, you can help reviewing the initial PR or picking-up another issue. Thanks for your contribution :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR resolves issue #1667 by upgrading the
github.com/gophercloud/gopherclouddependency from v1 to v2.The upgrade to v2 introduces several breaking API changes that have been addressed in this PR. Most notably, the
gophercloudSDK is now context-aware, requiring acontext.Contextobject to be passed as the first argument to all functions that make HTTP calls. All relevant OpenStack API calls inplatform/api/openstack/api.gohave been updated to usecontext.TODO().Additionally, several modules have been reorganized or deprecated in v2. The
imageservicemodule has been renamed toimage(Glance API). Furthermore, the deprecated Compute (Nova) Floating IP extension has been completely removed in v2, so the floating IP logic has been structurally rewritten to use the modern Networking (Neutron) API.How to use
Reviewers should verify that the new Neutron Floating IP logic correctly provisions and associates floating IPs during server creation, as the underlying OpenStack API calls have completely changed from Nova to Neutron. Ensure that
Mantlecan still successfully create and delete instances with floating IPs on OpenStack.Testing done
Successfully built the
openstackplatform package locally targeting the Linux OS environment to verify there are no compilation errors with the newgophercloud/v2SDK.Command run:
$env:GOOS="linux"; go build ./platform/api/openstack/...Output: Extracted successfully with exit code 0.
changelog/directory (user-facing change, bug fix, security fix, update)/bootand/usrsize, packages, list files for any missing binaries, kernel modules, config files, kernel modules, etc.