Skip to content

hetzner: Minor bug fixes #919

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
Harsh-2005d wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

hetzner: Minor bug fixes #919

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 9 additions & 4 deletions platform/api/hetzner/api.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -165,15 +165,18 @@ func (a *API) CreateSSHKey(ctx context.Context, name, publicKey string) (*SSHKey
Labels: DefaultLabels,
})
if err != nil {
return nil, err
return nil, fmt.Errorf("creating ssh key: %w", err)
}

return &SSHKey{sshKey}, nil
}

func (a *API) DeleteSSHKey(ctx context.Context, key *SSHKey) error {
_, err := a.client.SSHKey.Delete(ctx, key.SSHKey)
return err
if err != nil {
return fmt.Errorf("deleting ssh key: %w", err)
}
return nil
}

func (a *API) CreateNetwork(ctx context.Context, name string) (*Network, error) {
Expand Down Expand Up @@ -223,10 +226,12 @@ func (a *API) UploadImage(ctx context.Context, name, path, board string) (int64,
if parsedUrl.Scheme != "" {
opts.ImageURL = parsedUrl
} else {
opts.ImageReader, err = os.Open(path)
f, err := os.Open(path)
if err != nil {
return 0, fmt.Errorf("opening local path: %w", err)
}
defer f.Close()
opts.ImageReader = f
}

switch board {
Expand All @@ -253,7 +258,7 @@ func (a *API) GC(ctx context.Context, gracePeriod time.Duration) error {
}

if err := a.gcImages(ctx, createdCutoff); err != nil {
return fmt.Errorf("failed to gc servers: %w", err)
return fmt.Errorf("failed to gc images: %w", err)
}

if err := a.gcSSHKeys(ctx, createdCutoff); err != nil {
Expand Down
Loading