kola: fix architecture() for qemu-unpriv - #908
Open
AnshulPatil2005 wants to merge 1 commit into
Open
Conversation
Signed-off-by: Anshul <anshulpatil1022@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
architecture()decides which kolet binary to upload, based on the platform'sboard. It only special-cased
qemu, soqemu-unprivalways resolved toamd64even with an arm64 board, and the wrong-arch kolet got uploaded (failswith "Exec format error" on arm64 qemu-unpriv native-func tests).
qemu-unpriv runs off the same
QEMUOptionsas qemu, andFilterTestsalreadytreats qemu-unpriv like qemu, so this just aligns
architecture()with that.Adds a regression test (
TestArchitecture) that fails on the old code andpasses on the fix.
Closes flatcar/Flatcar#2290