Skip to content

fix(OSQUERY-010): CU-86akhf8u2 openframe/ header does not follow osquery/ structural conventions #74

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
flamingo wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

fix(OSQUERY-010): CU-86akhf8u2 openframe/ header does not follow osquery/ structural conventions #74

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 15 additions & 1 deletion openframe/openframe_token_extractor.h
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,9 +1,21 @@
/**
* Copyright (c) 2014-present, Facebook, Inc.
* All rights reserved.
*
* This source code is licensed under both the Apache 2.0 license (found in the
* LICENSE file in the root directory of this source tree) and the GPLv2 (found
* in the COPYING file in the root directory of this source tree).
* You may select, at your option, one of the above-listed licenses.
*/

#pragma once

@flamingo flamingo Bot Sep 21, 2026

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🦩 🔴 openframe/ header does not follow osquery/ structural conventions

Added the standard osquery copyright header comment block at the top of openframe/openframe_token_extractor.h and wrapped the OpenframeTokenExtractor class declaration in namespace osquery { ... }, addressing the missing copyright header and missing namespace wrapping conventions cited in OSQUERY-010. The Status-based error return convention was not applicable here since this header declares no exception-based error paths to convert; the corresponding .cpp file (not provided) would need similar review for that aspect.

🤖 Prompt for AI agents 
In openframe/openframe_token_extractor.h around line 1, review and complete this code-review fix: openframe/ header does not follow osquery/ structural conventions.
What the draft fix changed: Added the standard osquery copyright header comment block at the top of openframe/openframe_token_extractor.h and wrapped the OpenframeTokenExtractor class declaration in `namespace osquery { ... }`, addressing the missing copyright header and missing namespace wrapping conventions cited in OSQUERY-010. The Status-based error return convention was not applicable here since this header declares no exception-based error paths to convert; the corresponding .cpp file (not provided) would need similar review for that aspect.
Verify the change is correct and complete; do not refactor unrelated code.

fix confidence: 🟡 75 medium — react 👍/👎 to teach the reviewer


#include <string>
#include <memory>
#include "openframe_encryption_service.h"

namespace osquery {

class OpenframeTokenExtractor {
public:
explicit OpenframeTokenExtractor(std::shared_ptr<OpenframeEncryptionService> encryption_service,
Expand All @@ -16,4 +28,6 @@ class OpenframeTokenExtractor {
private:
std::string token_file_path_;
std::shared_ptr<OpenframeEncryptionService> encryption_service_;
};
};

} // namespace osquery
Loading