Repository navigation
fix(next-styles): the complete sheet is built from the app's own Tailwind content CU-17tkuw62qwh - #2937
Merged
Conversation
…wind content CU-17tkuw62qwh The route step runs inside next build since #2918, under NEXT_STYLES=routes, so the config it loaded was the root-sheet one with empty content: the complete sheet held no utilities and every page lost what it renders after paint. withRouteStylesTailwind now keeps the app config, and the route step builds the complete sheet from it.
Contributor
🦩 Flamingo Code Review✅ No findings on the current head. Advisory: findings do not block the merge.
✅ What this change does well
Review again. New commits are not reviewed until you ask:
Or comment Updated 2026-11-02 15:37 UTC · reviewed from Pavlo Shylo's machine |
pavlo-flamingo
enabled auto-merge
November 2, 2026 15:45
oleksandr-blip
approved these changes
Nov 2, 2026
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
Nov 2, 2026
This was referenced Nov 2, 2026
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem. Since #2918 the complete sheet (
next-styles/full-*.css) holds no Tailwind utilities: on OpenFrame (frontendmainafter #776, lib 0.0.838) it is 8 KB of globals and xterm, so everything a page renders after paint (the signed-in shell, menus, panels, client navigation) is unstyled.Cause. The route step now runs inside
next build, underNEXT_STYLES=routes. The Tailwind config it loads is therefore the onewithRouteStylesTailwindwrapped for the root sheet, with emptycontent, andfullSheet(null)builds from that.Fix.
withRouteStylesTailwindkeeps the app config underSymbol.for('next-styles.app-tailwind-config');stylesheetBuilderbuilds from it when present. Test: the complete sheet carries the app's utilities whileNEXT_STYLES=routes(red before the fix).Checked on a frontend
mainbuild with these two scripts dropped into 0.0.838:full-*.css8 KB → 282 KB raw (27 KB brotli),.flex/.hidden/.bg-ods-bg/content-md:present, standalone copy included.Change-Set: fix-route-styles-full-sheet
Change set
flamingo-stack/fix-route-styles-full-sheet: these pull requests are one change, reviewed together.Linked work
Linked by the
Depends-On/Change-Setlines in these descriptions; this block is maintained by the hub.