Skip to content

feat(trust-center): offer the Trust Center page as a PDF - #2599

Merged
michaelassraf merged 8 commits into
mainfrom
feat/trust-center-pdf-export
Oct 10, 2026
Merged

michaelassraf merged 8 commits into
mainfrom
feat/trust-center-pdf-export

Conversation

@michaelassraf

@michaelassraf michaelassraf commented Oct 9, 2026 •

Copy link
Copy Markdown
Contributor

What

The Trust Center page gets a Download PDF action in its header. It opens the hub's pdf route beside the page's endpoint (trustCenterPdfUrl), so an embed proxy carries it the same way it carries public documents.

Three rules move from the page into types/trust-center.ts, so the hub's PDF and the page cannot disagree:

  • visibleTrustCenterSections(data): which sections show, in reading order.
  • trustCenterMonitoringStatus(data, nowMs): the monitoring claim and its wording.
  • trustCenterPdfUrl(endpoint): where the page downloads as a PDF.

No change to what the page shows other than the new button.

Checked

  • trust-center-page.test.tsx: 35 pass, including the new action (href beside the endpoint, query string kept, new tab).
  • Type check, lint and format clean.
  • Run against the hub's dev server: the button renders and downloads the file.

Merge order

This one first. The hub pull request imports the new exports and needs the release that carries them.

Change-Set: feat-trust-center-pdf-export
ClickUp task: CU-17tkuw5w0k7 Trust Center: add PDF export + add Anthropic as subprocessor

🤖 Generated with Claude Code

Change set flamingo-stack/openframe-oss-lib#2599: these pull requests are one change, reviewed together.

Linked work

Linked by the Depends-On / Change-Set lines in these descriptions; this block is maintained by the hub.

… section and monitoring rules with the file [preview:none]

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@michaelassraf

Copy link
Copy Markdown
Contributor Author

@github-actions

github-actions Bot commented Oct 9, 2026 •

Copy link
Copy Markdown
Contributor

🦩 Flamingo Code Review

2 findings: 🔴 0 action required · 🟠 0 recommended · 🔵 2 informational

Advisory: findings do not block the merge.

2 defects outside any rule

Inline comments: 2 new

2 possible problems checked and ruled out
  • openframe-frontend-core/src/components/ui/data-attribution.tsx:4 DataAttributionProps gets a new action prop consumed by two external repos pinning this package: The added action prop is optional and additive (data-attribution.tsx:12), so per the rule that an added optional prop does not break consumers, this is not a breaking change despite the graph flag.
  • openframe-frontend-core/src/components/help-center-pages/trust-center-sections.tsx:74 13 new or changed definitions have no test referencing them: Generic missing-test note for style constants and type aliases/pure derivations; not worth acting on for trivial exports.
🤖 Prompt for AI agents: fix every finding
Address these code-review findings on pull request #2599 of flamingo-stack/openframe-oss-lib, most important first.
For each one, make the minimal change that resolves it and do not refactor unrelated code.
If you can show a finding is wrong, skip it and say why.

1. [Informational] openframe-frontend-core/src/components/help-center-pages/trust-center-sections.tsx:74 Spacing token renamed to a token that doesn't appear to exist (`--spacing-system-xsf` replacing `--spacing-system-xxs`) in two unrelated layout classes
   TRUST_STATUS_ROW_CLASS and the DataAttribution skeleton wrapper previously used `var(--spacing-system-xxs)` for the column gap below `content-md`/`content-sm`. The diff silently swaps this to `var(--spacing-system-xsf)` — the same token already used for the inner item gap (`ITEM_CLASS`, `gap-[var(--spacing-system-xsf)]`) a few lines below in both files. This looks like a copy-paste/typo rather than an intentional design change: it is unrelated to the PDF-download feature this PR is about, and if `--spacing-system-xxs` and `--spacing-system-xsf` are different token values, this silently changes vertical spacing in the Trust Center status row and its skeleton for every consumer of this shared component, with no corresponding visual/test justification in the diff.
2. [Informational] openframe-frontend-core/src/components/help-center-pages/trust-center-sections.tsx:678 Same unexplained spacing-token swap in the TrustCenterSkeleton wrapper
   Same issue as in TRUST_STATUS_ROW_CLASS: the skeleton's outer wrapper changes from `--spacing-system-xxs` to `--spacing-system-xsf`, duplicating the token already used by the nested item row (`gap-[var(--spacing-system-xsf)]` two lines below), unrelated to the PDF download feature. If unintentional, the skeleton will no longer visually match the real DataAttribution row it is meant to mirror (the file's own comment says they must match).

Next: commit a suggestion, or hand a comment's prompt to your coding agent. React 👍 on a finding that helped and 👎 on one that is wrong: the reviewer learns from both.

Review again. New commits are not reviewed until you ask:

  • Review the new commits: only what was pushed since this review
  • Review the whole diff again: everything, including what was already reviewed

Or comment @flamingo-review (new commits) or @flamingo-review full (everything). Add the flamingo-review-always label to review every push.

Updated 2026-10-10 02:20 UTC · reviewed from Michael Assraf's machine

michaelassraf and others added 5 commits October 9, 2026 20:52
…uiet link under the title, never in the bottom bar (showOnlyDesktop page actions) [preview:none]

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…at the end of the status line, in that line's type; no header button, no bottom bar [preview:none]

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…tton; the Trust Center's PDF uses it in the status line [preview:none]

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…status lines stack with even 8px spacing on a phone [preview:none]

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…olour of the facts beside it (the link variant) [preview:none]

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
michaelassraf and others added 2 commits October 9, 2026 22:28
…e the FAQ, so the FAQ closes the page [preview:none]

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…ll content width, like the FAQ on every other page [preview:none]

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@michaelassraf
michaelassraf merged commit c7e05af into main Oct 10, 2026
15 of 17 checks passed
@michaelassraf
michaelassraf deleted the feat/trust-center-pdf-export branch October 10, 2026 02:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant