Repository navigation
Scripts: Back from a directly opened execution resolves the script; ↗ opens in a new tab. CU-17tkuw5ty38 - #532
Merged
Conversation
… opens executions and runs in a new tab. CU-17tkuw5ty38 Script Execution Details built its Back target from `scriptId`, the raw DB id, while Script Details resolves `?id=` through `node(id:)` — so Back from a page opened by URL failed with "Couldn't load this script". Encode it as a Script global id. The ↗ on the Execution History and schedule-runs rows did a same-tab push (identical to the row click); it now opens a new tab like every other ↗. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
Contributor
🦩 Flamingo Code ReviewNo findings on the current head. Mode: advisory Need another pass? Commits pushed after this review are not reviewed automatically.
Prefer typing? Comment React 👍/👎 on inline comments to teach the reviewer. Started 2026-10-02 12:26 UTC · updated 2026-10-02 12:28 UTC · workflow run |
oleksandr-blip
enabled auto-merge (squash)
October 2, 2026 12:28
romanivan-flamingo
approved these changes
Oct 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes Back on Script Execution Details opened via direct link leads to "Couldn't load this script".
Back target.
ScriptExecution.scriptIdis the raw DB id, but Script Details resolves?id=throughnode(id:), so Back from an execution opened by URL navigated to/scripts/details?id=<raw>and failed withexpecting a valid global id. In-app it only worked because Back used browser history. The target is nowensureGlobalIdForType('Script', scriptId), which matches the id the in-app link uses.↗ on Execution History / schedule runs. Both did a same-tab
router.push, identical to clicking the row. They now useopenInNewTab, like every other ↗ in the app.Verified on localhost against a live backend: opened an execution by URL in a fresh tab, clicked Back, and Script Details → Execution History loaded. The ↗ on an Execution History row opened the execution in a new tab. Lint (
eslint.ci.mjs), Prettier andtscpass. Not browser-checked: the ↗ on schedule runs (same one-line change).Change-Set: fix-script-execution-back-link
🤖 Generated with Claude Code
Change set
flamingo-stack/fix-script-execution-back-link: this pull request is the only one in it so far. Another pull request joins by naming this one in aDepends-Online, or by carrying the sameChange-Setline.Linked work
Linked by the
Depends-On/Change-Setlines in these descriptions; this block is maintained by the hub.