feat!: Making add,addAll sync methods#3968
Open
erickzanardo wants to merge 4 commits into
Open
Conversation
erickzanardo
marked this pull request as draft
July 22, 2026 14:39
erickzanardo
commented
Jul 22, 2026
erickzanardo
marked this pull request as ready for review
July 22, 2026 18:16
spydon
reviewed
Jul 22, 2026
Comment on lines
+223
to
+224
| world.add(coin); | ||
| await coin.mounted; |
Member
There was a problem hiding this comment.
One footgun with this is that if they do this in onLoad of the component they are adding to it will be a deadlock
| @override | ||
| Future<void> onLoad() async { | ||
| await add(MyCrate()); | ||
| void onLoad() { |
Member
There was a problem hiding this comment.
The signature of onLoad shouldn't change right? I think super.onLoad might be needed here too?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Makes
add,addAllandaddToParentmethods sync.Checklist
docsand added dartdoc comments with///.examplesordocs.Breaking Change?
Related Issues
Indicate which issues this PR resolves, if any. For example:
Part of #1938