refactor(a11y): centralize tree queries - #527
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
What
AxTreeAxTreeoperation while retaining the free-function APIWhy
Tree traversal was split between the accessibility model and session-specific recursive helpers. Keeping traversal mechanics on
AxTreegives callers one query boundary while leaving wait, click, and popover policy in the session layer.How
AxTree::find_firstowns pre-order predicate traversal,AxTree::path_toowns root-to-target traversal, andAxTree::element_matchcomposes selector and condition semantics from those primitives. Existing diagnostics and behavior are unchanged.Testing
cargo fmt --all -- --checkcargo test --workspacecargo clippy --workspace --all-targets -- -D warnings