Skip to content

refactor(doctor): classify bounded probe outcomes - #526

Merged
xxx merged 1 commit into
masterfrom
mpd/classify-bounded-probe-outcomes
Aug 25, 2026
Merged

refactor(doctor): classify bounded probe outcomes#526
xxx merged 1 commit into
masterfrom
mpd/classify-bounded-probe-outcomes

Conversation

@xxx

@xxx xxx commented Aug 25, 2026

Copy link
Copy Markdown
Contributor

Description

What

  • add BoundedRun, a structured outcome for bounded one-shot commands
  • migrate the Android and iOS doctor probes away from direct BoundKind inspection
  • cover answered, timed-out, not-started, and ordinary-failure outcomes

Why

Doctor probes repeatedly translated the same bounded execution facts before assigning backend-specific findings. Keeping those facts structured in glass-core improves locality and prevents callers from drifting toward message-based classification.

How

run_bounded_classified delegates to the existing bounded runner and classifies only its structured BoundKind. Callers retain ownership of logging, diagnosis text, and remedies, so user-visible behavior remains unchanged.

Testing

  • cargo fmt --all -- --check
  • cargo test --workspace
  • cargo clippy --workspace --all-targets -- -D warnings

@xxx
xxx marked this pull request as draft August 25, 2026 19:14
@xxx
xxx marked this pull request as ready for review August 25, 2026 19:27
@xxx
xxx merged commit 2b71e56 into master Aug 25, 2026
17 checks passed
@xxx
xxx deleted the mpd/classify-bounded-probe-outcomes branch August 25, 2026 19:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant