fix(a11y-linux): an <iframe> is a Group, not a Window (fixes #520) - #523
Merged
Conversation
AT-SPI's `internal frame` mapped to `AxRole::Window`, so a browser page's iframes — and Firefox's own docshells — arrived as windows nested inside the page, and a `role:"Window"` selector matched them. Nothing on the desktop side wants that mapping: GTK 3.24.41 never references the role, GTK 4.14.5 declares it in its AT-SPI enum copy without ever returning it, and Qt's role table has no entry for it. Firefox 153 and Chromium are the only producers, both for embedded frames. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
AT-SPI's
internal framemapped toAxRole::Window, so a page's iframes arrived as windows inside the page and arole:"Window"selector matched them. No desktop toolkit publishes the role — GTK 3.24.41, GTK 4.14.5 and Qt never return it, and only Firefox and Chromium emit it, for embedded frames — so it maps toGroup. The reading behind that is in #520.