ci: drop the Miri job - #503
Merged
Merged
Conversation
On the Linux runner every `unsafe` block in glass-clip-shim-windows and glass-windows is behind `#[cfg(windows)]`, so `cargo miri test` interpreted 117 tests' worth of entirely safe code — the same tests the `check` job already runs, with no UB left for Miri to find. The Win32 hook, the detours and the named-pipe server are FFI, which Miri cannot execute at all; they stay covered by the on-box suite and review. Also drops the now-dead `#[cfg_attr(miri, ignore)]` and the doc comments claiming Miri coverage. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On the Linux runner every
unsafeblock inglass-clip-shim-windowsandglass-windowssits behind#[cfg(windows)], socargo miri testwas interpreting 117 tests' worth of entirely safe code — the same testscheckalready runs, with no UB available for Miri to find. The Win32 hook, the user32 detours and the named-pipe server are FFI, which Miri cannot execute at all; those stay covered on-box and by review.Also removes the now-dead
#[cfg_attr(miri, ignore)]and the doc comments that claimed Miri coverage.Needs a ruleset edit before merge:
Miri (UB check · pure crates)is still a required status check, so this PR will sit unmergeable until it is dropped from the ruleset.🤖 Generated with Claude Code