ci: run ledger tests with default DB cache - #11411
Open
ripatel-fd wants to merge 1 commit into
Open
ripatel-fd wants to merge 1 commit into
ripatel-fd wants to merge 1 commit into
Conversation
┌─ ⚡ PERF · 0526ea6 vs main@2fc40e5 ─────────────────────────────────
│ SUITE BASELINE NEW Δ
│ replay tps, mainnet 28,572 tps 28,648 tps · +0.26%
│ bench tps, localnet 128,616 tps 128,642 tps · +0.02%
│ snapshot load, testnet 15.93 s 16.17 s · +1.52%
│ mem total, mainnet 171.44 GiB 171.44 GiB · 0.00%
│ mem total, testnet 102.31 GiB 102.31 GiB · 0.00%
│ clean compile, firedancer 241.8 cpu·s 243.9 cpu·s · +0.89%
│ binary size, firedancer 85.94 MB 85.94 MB · 0.00%
├─────────────────────────────────────────────────────────────────────
@@ 0 REGRESSIONS · 0 WARNINGS · 0 IMPROVED · 7 NOISE @@
└───────────────────────────────────────────────────────────────────── |
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
Both targeted configurations now correctly inherit the validated default cache size.
Pull request overview
Runs ledger and benchmark tests with the production-default 12 GiB accounts database cache.
Changes:
- Removes the 3 GiB cache override from ledger backtests.
- Removes the same override from CI benchmarks.
File summaries
| File | Description |
|---|---|
src/flamenco/runtime/tests/run_ledger_backtest.sh |
Uses the default accounts cache size. |
contrib/ci/bench/bench.toml |
Uses the default cache for benchmarks. |
Review details
- Files reviewed: 2/2 changed files
- Comments generated: 0
- Review effort level: Balanced
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.