config: support hostnames for additional shred destinations - #11407
Open
esemeniuc wants to merge 1 commit into
Open
config: support hostnames for additional shred destinations#11407esemeniuc wants to merge 1 commit into
esemeniuc wants to merge 1 commit into
Conversation
Resolve additional shred destinations through the system IPv4 resolver before starting tiles, and pass numeric endpoints through the topology. Keep admin commands independent of DNS and reuse resolved destinations in child processes.
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
Endpoint validation, startup ordering, cross-tile reuse, and relevant edge cases are implemented consistently and covered by tests.
Pull request overview
Adds hostname support for additional shred destinations while preserving numeric IPv4 behavior.
Changes:
- Parses and resolves
host:portendpoints once before tile startup. - Reuses resolved endpoints across shred tiles and child processes.
- Expands configuration storage, documentation, and resolver tests.
File summaries
| File | Description |
|---|---|
src/disco/topo/fd_dns_resolve.c |
Prevents long IPv4-prefixed hostnames from bypassing DNS. |
src/app/shared/test_config_parse.c |
Tests validation, resolution, and endpoint reuse. |
src/app/shared/fd_config.h |
Expands destination buffers for hostnames. |
src/app/shared/fd_config.c |
Adds endpoint resolution and tile propagation. |
src/app/shared/fd_config_private.h |
Declares the new internal helpers. |
src/app/shared/fd_config_json.c |
Updates the configuration layout assertion. |
src/app/shared/commands/run/run1.c |
Resolves destinations for standalone shred tiles. |
src/app/shared/commands/run/run.c |
Resolves destinations before startup serialization. |
src/app/firedancer/topology.c |
Removes numeric-only topology parsing. |
src/app/firedancer/config/default.toml |
Documents hostname behavior for Firedancer. |
src/app/firedancer-dev/commands/forktest/forktest.c |
Resolves destinations before forktest startup. |
src/app/fdctl/topology.c |
Removes numeric-only Frankendancer parsing. |
src/app/fdctl/config/default.toml |
Documents hostname behavior for Frankendancer. |
Review details
- Files reviewed: 13/13 changed files
- Comments generated: 0
- Review effort level: Balanced
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
esemeniuc
marked this pull request as ready for review
September 10, 2026 20:28
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The additional leader and retransmit shred destinations currently accept only IPv4 endpoints. Allow DNS/NSS
host:portvalues in Firedancer and Frankendancer, such asshred-receiver.example.com:5566Resolve each configured hostname once at tile startup using the system resolver's first IPv4 result, then reuse the numeric endpoints across shred tiles and child processes. Unresolvable hosts fail startup; DNS changes require a restart. IPv6 remains unsupported. Also prevent long hostnames beginning with an IPv4-looking prefix from bypassing the system resolver