runtime: fix fd_log_collector_printf_dangerous_max_127 bounds derivat… - #11405
Open
two-heart wants to merge 1 commit into
Open
runtime: fix fd_log_collector_printf_dangerous_max_127 bounds derivat…#11405two-heart wants to merge 1 commit into
two-heart wants to merge 1 commit into
Conversation
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
Both corrected calculations accurately bound their corresponding formatted messages.
Pull request overview
Corrects log-message size derivation comments in the BPF loader runtime.
Changes:
- Fixes maximum-size calculations for integer and Base58-formatted logs.
File summaries
| File | Description |
|---|---|
src/flamenco/runtime/program/fd_bpf_loader_program.c |
Corrects two log-size bounds comments. |
Review details
- Files reviewed: 1/1 changed files
- Comments generated: 0
- Review effort level: Balanced
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…ion comments