Conversation
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
The new bound ignores the scheduler’s configurable shred limit and lacks regression coverage.
Once you've addressed the issues Copilot identified, you can request another Copilot review.
Pull request overview
Updates the scheduler’s microblock limit to reflect maximum shred payload capacity.
Changes:
- Derives the microblock limit from slot payload capacity.
- Corrects the limit diagnostic comparison operator.
File summaries
| File | Description |
|---|---|
src/discof/replay/fd_sched.c |
Updates microblock bounds and logging. |
Review details
Suppressed comments (1)
src/discof/replay/fd_sched.c:25
- Please add a scheduler regression case that declares a microblock count just above the old
MAX_SKIPPED_TICKSbound but within this new bound, and a boundary case above the new bound.test_sched.calready exercises parser rejection reasons, but currently has noTOO_MANY_MICROBLOCKScoverage, so the behavior this PR is intended to fix can regress unnoticed.
(FD_SHRED_DATA_PAYLOAD_MAX_PER_SLOT / sizeof(fd_microblock_hdr_t))
- Files reviewed: 1/1 changed files
- Comments generated: 1
- Review effort level: Balanced
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
only relevant after very long period of skipped slots
two-heart
force-pushed
the
sched-entry-sizing
branch
from
September 8, 2026 10:43
be0b3f2 to
a34c0c0
Compare
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
The corrected boundary needs a regression test covering acceptance above the former limit and rejection above the new limit.
Once you've addressed the issues Copilot identified, you can request another Copilot review.
Review details
- Files reviewed: 1/1 changed files
- Comments generated: 1
- Review effort level: Balanced
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
only relevant after very long period of skipped slots