runtime: cost tracker polishing - #11340
Open
ripatel-fd wants to merge 1 commit into
Open
Conversation
┌─ ⚡ PERF · f608472 vs main@d744a76 ─────────────────────────────────
│ SUITE BASELINE NEW Δ
!│ replay tps, mainnet 28,440 tps 28,224 tps ▼ -0.76%
│ bench tps, localnet 128,646 tps 128,646 tps · 0.00%
│ snapshot load, testnet 15.61 s 15.45 s · -1.04%
!│ mem total, mainnet 171.43 GiB 172.43 GiB ▲ +0.58%
!│ mem total, testnet 102.30 GiB 103.30 GiB ▲ +0.98%
│ clean compile, firedancer 232.7 cpu·s 235.2 cpu·s · +1.11%
│ binary size, firedancer 85.81 MB 85.81 MB · 0.00%
├─────────────────────────────────────────────────────────────────────
@@ 0 REGRESSIONS · 3 WARNINGS · 0 IMPROVED · 4 NOISE @@
└───────────────────────────────────────────────────────────────────── |
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
All reviewed changes are consistent, with no unresolved issues.
Pull request overview
Aligns cost-tracker capacity and tests with the 100M CU block limit.
Changes:
- Raises the writable-account bound to 321,282.
- Generalizes compile-time bound checks.
- Reuses canonical pack limits in tests.
File summaries
| File | Description |
|---|---|
src/flamenco/runtime/test_cost_tracker.c |
Uses shared limit constants in reconciliation tests. |
src/flamenco/runtime/fd_runtime_const.h |
Updates writable-account capacity and derivation. |
src/flamenco/runtime/fd_cost_tracker.h |
Generalizes tight-bound assertions. |
Review details
- Files reviewed: 3/3 changed files
- Comments generated: 0
- Review effort level: Balanced
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
ripatel-fd
enabled auto-merge (rebase)
September 8, 2026 07:25
Contributor
|
See discussion on Slack, I don't think we need to merge this |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
security fix, needs v26.09 backport