Skip to content

[WIP] offline-replay: resolve OBJDIR from the built binary #11291

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
kbhargava-jump wants to merge 2 commits into
base: main
Choose a base branch
from
Open

[WIP] offline-replay: resolve OBJDIR from the built binary #11291

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0d15681
offline-replay: resolve OBJDIR from the build config
kbhargava-jump Sep 4, 2026
04a4e35
offline-replay: run configure fini on affinity/startup failure (skip …
kbhargava-jump Sep 4, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion contrib/offline-replay/run_offline_replay_backtest.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -316,7 +316,11 @@ build_firedancer() {
EXTRAS=offline-replay make -j

OBJDIR=$(EXTRAS=offline-replay make --silent --no-print-directory objdir 2>/dev/null || true)
: "${OBJDIR:?cannot determine OBJDIR (make objdir failed)}"
if [ -z "$OBJDIR" ] || [ ! -x "$OBJDIR/bin/firedancer-dev" ]; then
Comment thread
kbhargava-jump marked this conversation as resolved.
send_slack_message "@here offline-replay: firedancer-dev not found at \`${OBJDIR:-<unresolved>}/bin\` after build (OBJDIR/build-config mismatch, not a ledger failure). Exiting."
exit 1
fi
export OBJDIR
}

# Convert the downloaded rocksdb into a shredcap capture covering the replay
Expand Down Expand Up @@ -614,6 +618,7 @@ replay_until_clean() {
# config, permissions, ...) — that is an infrastructure problem, not
# a ledger mismatch, so there is nothing to minimize.
if [ "$status" -ne 0 ] && [ ! -s "$TEMP_LOG" ]; then
sudo -E $OBJDIR/bin/firedancer-dev configure fini all --config $LEDGER_DIR/offline_replay.toml &> /dev/null || true
send_slack_message "@here Backtest produced no log output; firedancer-dev likely failed at startup. See the configure output in the harness log. Exiting."
exit 1
fi
Expand Down
5 changes: 5 additions & 0 deletions src/flamenco/runtime/tests/run_ledger_backtest.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -294,6 +294,8 @@ fi

echo_notice "Running backtest for $LEDGER"

[ -x "$OBJDIR/bin/firedancer-dev" ] || { echo "error: firedancer-dev not found at \"$OBJDIR/bin\" -- build it, or set OBJDIR/EXTRAS" >&2; exit 1; }

sudo killall firedancer-dev &> /dev/null || true

set -x
Expand Down Expand Up @@ -325,6 +327,9 @@ if [ "$status" -eq 0 ]; then
exit 0
fi

if [ -z "$CI" ] && grep -q "Unable to set the thread affinity" "$LOG"; then
$OBJDIR/bin/firedancer-dev configure fini all --config ${DUMP_DIR}/${LEDGER}_backtest.toml &> /dev/null || true
fi
tail -n 10 $LOG
echo "Failed with status: $status"

Expand Down
Loading