alpenglow: derive bls pubkeys from auth voters - #11284
Open
ibhatt-jumptrading wants to merge 1 commit into
Open
Conversation
ibhatt-jumptrading
requested review from
emwang-jump and
lidatong
as code owners
September 3, 2026 19:34
Performance Measurements ⏳
|
Contributor
There was a problem hiding this comment.
🔵 Needs a closer look
Consensus-critical cryptographic key selection warrants final human review despite no identified defects.
Pull request overview
Enables epoch-specific Alpenglow BLS signing keys derived from the identity and configured authorized voters.
Changes:
- Derives and securely stores candidate BLS keypairs.
- Selects the registered key per epoch and disables voting when unavailable.
- Adds epoch key-rotation and missing-key tests.
File summaries
| File | Description |
|---|---|
src/discof/votor/fd_votor_tile.c |
Derives and selects authorized-voter BLS keys. |
src/disco/topo/fd_topo.h |
Adds authorized-voter paths to votor configuration. |
src/choreo/votor/test_ag_votor.c |
Tests key rotation and disabled voting. |
src/choreo/votor/ag_votor.h |
Documents epoch BLS-key ownership. |
src/choreo/votor/ag_votor.c |
Tracks current and next epoch signing keys. |
src/app/firedancer/topology.c |
Passes configured voter paths to the votor tile. |
Review details
- Files reviewed: 6/6 changed files
- Comments generated: 0
- Review effort level: Balanced
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.