Skip to content

chore: add FlutterFramework dependency to plugins' Package.swift files #18293

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
SelaseKay merged 8 commits into from
Aug 4, 2026
Merged

chore: add FlutterFramework dependency to plugins' Package.swift files #18293

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
ad7e384
chore: add FlutterFramework dependency to plugins' Package.swift
SelaseKay May 19, 2026
bc9f887
chore: update font_awesome_flutter to 11.0.0
SelaseKay May 19, 2026
7f76480
chore: remove unused dependencies from example app's pubspec.yaml
SelaseKay May 19, 2026
ffe8c13
chore: disable Swift Package Manager in iOS and macOS workflows
SelaseKay May 19, 2026
c1db83e
chore: remove Swift Package Manager disable step from iOS and macOS w…
SelaseKay May 21, 2026
0edf626
chore: refactor authentication button handling
SelaseKay Aug 4, 2026
d5fc45c
Merge branch 'main' into fix/spm-flutterframework-dependency
SelaseKay Aug 4, 2026
de1cdb5
fix formatting
SelaseKay Aug 4, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions packages/cloud_firestore/cloud_firestore/ios/cloud_firestore/Package.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,13 +21,15 @@ let package = Package(
dependencies: [
.package(url: "https://github.com/firebase/firebase-ios-sdk", exact: firebaseSdkVersion),
.package(name: "firebase_core", path: "../firebase_core"),
.package(name: "FlutterFramework", path: "../FlutterFramework"),
],
targets: [
.target(
name: "cloud_firestore",
dependencies: [
.product(name: "FirebaseFirestore", package: "firebase-ios-sdk"),
.product(name: "firebase-core", package: "firebase_core"),
.product(name: "FlutterFramework", package: "FlutterFramework"),
],
resources: [
.process("Resources")
Expand Down
2 changes: 2 additions & 0 deletions packages/cloud_firestore/cloud_firestore/macos/cloud_firestore/Package.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,13 +21,15 @@ let package = Package(
dependencies: [
.package(url: "https://github.com/firebase/firebase-ios-sdk", exact: firebaseSdkVersion),
.package(name: "firebase_core", path: "../firebase_core"),
.package(name: "FlutterFramework", path: "../FlutterFramework"),
],
targets: [
.target(
name: "cloud_firestore",
dependencies: [
.product(name: "FirebaseFirestore", package: "firebase-ios-sdk"),
.product(name: "firebase-core", package: "firebase_core"),
.product(name: "FlutterFramework", package: "FlutterFramework"),
],
resources: [
.process("Resources")
Expand Down
2 changes: 2 additions & 0 deletions packages/cloud_functions/cloud_functions/ios/cloud_functions/Package.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,13 +20,15 @@ let package = Package(
dependencies: [
.package(url: "https://github.com/firebase/firebase-ios-sdk", exact: firebaseSdkVersion),
.package(name: "firebase_core", path: "../firebase_core"),
.package(name: "FlutterFramework", path: "../FlutterFramework"),
],
targets: [
.target(
name: "cloud_functions",
dependencies: [
.product(name: "FirebaseFunctions", package: "firebase-ios-sdk"),
.product(name: "firebase-core", package: "firebase_core"),
.product(name: "FlutterFramework", package: "FlutterFramework"),
],
resources: [
.process("Resources")
Expand Down
2 changes: 2 additions & 0 deletions packages/cloud_functions/cloud_functions/macos/cloud_functions/Package.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,13 +20,15 @@ let package = Package(
dependencies: [
.package(url: "https://github.com/firebase/firebase-ios-sdk", exact: firebaseSdkVersion),
.package(name: "firebase_core", path: "../firebase_core"),
.package(name: "FlutterFramework", path: "../FlutterFramework"),
],
targets: [
.target(
name: "cloud_functions",
dependencies: [
.product(name: "FirebaseFunctions", package: "firebase-ios-sdk"),
.product(name: "firebase-core", package: "firebase_core"),
.product(name: "FlutterFramework", package: "FlutterFramework"),
],
resources: [
.process("Resources")
Expand Down
8 changes: 6 additions & 2 deletions packages/firebase_ai/firebase_ai/ios/firebase_ai/Package.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,11 +15,15 @@ let package = Package(
products: [
.library(name: "firebase-ai", targets: ["firebase_ai"])
],
dependencies: [],
dependencies: [
.package(name: "FlutterFramework", path: "../FlutterFramework")
],
targets: [
.target(
name: "firebase_ai",
dependencies: [],
dependencies: [
.product(name: "FlutterFramework", package: "FlutterFramework")
],
resources: [
.process("Resources")
]
Expand Down
8 changes: 6 additions & 2 deletions packages/firebase_ai/firebase_ai/macos/firebase_ai/Package.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,11 +15,15 @@ let package = Package(
products: [
.library(name: "firebase-ai", targets: ["firebase_ai"])
],
dependencies: [],
dependencies: [
.package(name: "FlutterFramework", path: "../FlutterFramework")
],
targets: [
.target(
name: "firebase_ai",
dependencies: [],
dependencies: [
.product(name: "FlutterFramework", package: "FlutterFramework")
],
resources: [
.process("Resources")
]
Expand Down
2 changes: 2 additions & 0 deletions packages/firebase_analytics/firebase_analytics/ios/firebase_analytics/Package.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,13 +26,15 @@ let package = Package(
dependencies: [
.package(url: "https://github.com/firebase/firebase-ios-sdk", exact: firebaseSdkVersion),
.package(name: "firebase_core", path: "../firebase_core"),
.package(name: "FlutterFramework", path: "../FlutterFramework"),
],
targets: [
.target(
name: "firebase_analytics",
dependencies: [
.product(name: analyticsProduct, package: "firebase-ios-sdk"),
.product(name: "firebase-core", package: "firebase_core"),
.product(name: "FlutterFramework", package: "FlutterFramework"),
],
resources: [
.process("Resources")
Expand Down
2 changes: 2 additions & 0 deletions packages/firebase_analytics/firebase_analytics/macos/firebase_analytics/Package.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,13 +20,15 @@ let package = Package(
dependencies: [
.package(url: "https://github.com/firebase/firebase-ios-sdk", exact: firebaseSdkVersion),
.package(name: "firebase_core", path: "../firebase_core"),
.package(name: "FlutterFramework", path: "../FlutterFramework"),
],
targets: [
.target(
name: "firebase_analytics",
dependencies: [
.product(name: "FirebaseAnalytics", package: "firebase-ios-sdk"),
.product(name: "firebase-core", package: "firebase_core"),
.product(name: "FlutterFramework", package: "FlutterFramework"),
],
resources: [
.process("Resources")
Expand Down
2 changes: 2 additions & 0 deletions packages/firebase_app_check/firebase_app_check/ios/firebase_app_check/Package.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,7 @@ let package = Package(
from: "18.0.0"
),
.package(name: "firebase_core", path: "../firebase_core"),
.package(name: "FlutterFramework", path: "../FlutterFramework"),
],
targets: [
.target(
Expand All @@ -32,6 +33,7 @@ let package = Package(
.product(name: "FirebaseAppCheck", package: "firebase-ios-sdk"),
.product(name: "RecaptchaEnterprise", package: "recaptcha-enterprise-mobile-sdk"),
.product(name: "firebase-core", package: "firebase_core"),
.product(name: "FlutterFramework", package: "FlutterFramework"),
],
resources: [
.process("Resources")
Expand Down
2 changes: 2 additions & 0 deletions packages/firebase_app_check/firebase_app_check/macos/firebase_app_check/Package.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,13 +20,15 @@ let package = Package(
dependencies: [
.package(url: "https://github.com/firebase/firebase-ios-sdk", exact: firebaseSdkVersion),
.package(name: "firebase_core", path: "../firebase_core"),
.package(name: "FlutterFramework", path: "../FlutterFramework"),
],
targets: [
.target(
name: "firebase_app_check",
dependencies: [
.product(name: "FirebaseAppCheck", package: "firebase-ios-sdk"),
.product(name: "firebase-core", package: "firebase_core"),
.product(name: "FlutterFramework", package: "FlutterFramework"),
],
resources: [
.process("Resources")
Expand Down
2 changes: 2 additions & 0 deletions ...app_installations/firebase_app_installations/ios/firebase_app_installations/Package.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,13 +20,15 @@ let package = Package(
dependencies: [
.package(url: "https://github.com/firebase/firebase-ios-sdk", exact: firebaseSdkVersion),
.package(name: "firebase_core", path: "../firebase_core"),
.package(name: "FlutterFramework", path: "../FlutterFramework"),
],
targets: [
.target(
name: "firebase_app_installations",
dependencies: [
.product(name: "FirebaseInstallations", package: "firebase-ios-sdk"),
.product(name: "firebase-core", package: "firebase_core"),
.product(name: "FlutterFramework", package: "FlutterFramework"),
],
resources: [
.process("Resources")
Expand Down
2 changes: 2 additions & 0 deletions ...p_installations/firebase_app_installations/macos/firebase_app_installations/Package.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,13 +20,15 @@ let package = Package(
dependencies: [
.package(url: "https://github.com/firebase/firebase-ios-sdk", exact: firebaseSdkVersion),
.package(name: "firebase_core", path: "../firebase_core"),
.package(name: "FlutterFramework", path: "../FlutterFramework"),
],
targets: [
.target(
name: "firebase_app_installations",
dependencies: [
.product(name: "FirebaseInstallations", package: "firebase-ios-sdk"),
.product(name: "firebase-core", package: "firebase_core"),
.product(name: "FlutterFramework", package: "FlutterFramework"),
],
resources: [
.process("Resources")
Expand Down
39 changes: 27 additions & 12 deletions packages/firebase_auth/firebase_auth/example/lib/auth.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,6 @@ import 'package:flutter/foundation.dart';
import 'package:flutter/gestures.dart';
import 'package:flutter/material.dart';
import 'package:flutter_facebook_auth/flutter_facebook_auth.dart';
import 'package:flutter_signin_button/flutter_signin_button.dart';
import 'package:google_sign_in/google_sign_in.dart';

typedef OAuthSignIn = void Function();
Expand Down Expand Up @@ -59,6 +58,20 @@ extension on AuthMode {
: 'Register';
}

enum OAuthButton {
apple('Apple'),
google('Google'),
github('GitHub'),
microsoft('Microsoft'),
twitter('Twitter'),
yahoo('Yahoo'),
facebook('Facebook');

const OAuthButton(this.providerName);

final String providerName;
}

/// Entrypoint example for various sign-in flows with Firebase.
class AuthGate extends StatefulWidget {
// ignore: public_member_api_docs
Expand Down Expand Up @@ -87,7 +100,7 @@ class _AuthGateState extends State<AuthGate> {
});
}

late Map<Buttons, OAuthSignIn> authButtons;
late Map<OAuthButton, OAuthSignIn> authButtons;

@override
void initState() {
Expand All @@ -100,31 +113,31 @@ class _AuthGateState extends State<AuthGate> {

if (!kIsWeb && Platform.isMacOS) {
authButtons = {
Buttons.Apple: () => _handleMultiFactorException(
OAuthButton.apple: () => _handleMultiFactorException(
_signInWithApple,
),
};
} else {
authButtons = {
Buttons.Apple: () => _handleMultiFactorException(
OAuthButton.apple: () => _handleMultiFactorException(
_signInWithApple,
),
Buttons.Google: () => _handleMultiFactorException(
OAuthButton.google: () => _handleMultiFactorException(
_signInWithGoogle,
),
Buttons.GitHub: () => _handleMultiFactorException(
OAuthButton.github: () => _handleMultiFactorException(
_signInWithGitHub,
),
Buttons.Microsoft: () => _handleMultiFactorException(
OAuthButton.microsoft: () => _handleMultiFactorException(
_signInWithMicrosoft,
),
Buttons.Twitter: () => _handleMultiFactorException(
OAuthButton.twitter: () => _handleMultiFactorException(
_signInWithTwitter,
),
Buttons.Yahoo: () => _handleMultiFactorException(
OAuthButton.yahoo: () => _handleMultiFactorException(
_signInWithYahoo,
),
Buttons.Facebook: () => _handleMultiFactorException(
OAuthButton.facebook: () => _handleMultiFactorException(
_signInWithFacebook,
),
};
Expand Down Expand Up @@ -254,9 +267,11 @@ class _AuthGateState extends State<AuthGate> {
: SizedBox(
width: double.infinity,
height: 50,
child: SignInButton(
button,
child: OutlinedButton(
onPressed: authButtons[button],
child: Text(
'Sign in with ${button.providerName}',
),
),
),
),
Expand Down
2 changes: 0 additions & 2 deletions packages/firebase_auth/firebase_auth/example/pubspec.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,8 +14,6 @@ dependencies:
flutter:
sdk: flutter
flutter_facebook_auth: ^7.1.5
flutter_signin_button: ^2.0.0
font_awesome_flutter: ^10.8.0
google_sign_in: ^6.1.0
google_sign_in_dartio: ^0.3.0

Expand Down
2 changes: 2 additions & 0 deletions packages/firebase_auth/firebase_auth/ios/firebase_auth/Package.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,13 +21,15 @@ let package = Package(
dependencies: [
.package(url: "https://github.com/firebase/firebase-ios-sdk", exact: firebaseSdkVersion),
.package(name: "firebase_core", path: "../firebase_core"),
.package(name: "FlutterFramework", path: "../FlutterFramework"),
],
targets: [
.target(
name: "firebase_auth",
dependencies: [
.product(name: "FirebaseAuth", package: "firebase-ios-sdk"),
.product(name: "firebase-core", package: "firebase_core"),
.product(name: "FlutterFramework", package: "FlutterFramework"),
],
resources: [
.process("Resources")
Expand Down
2 changes: 2 additions & 0 deletions packages/firebase_auth/firebase_auth/macos/firebase_auth/Package.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,13 +21,15 @@ let package = Package(
dependencies: [
.package(url: "https://github.com/firebase/firebase-ios-sdk", exact: firebaseSdkVersion),
.package(name: "firebase_core", path: "../firebase_core"),
.package(name: "FlutterFramework", path: "../FlutterFramework"),
],
targets: [
.target(
name: "firebase_auth",
dependencies: [
.product(name: "FirebaseAuth", package: "firebase-ios-sdk"),
.product(name: "firebase-core", package: "firebase_core"),
.product(name: "FlutterFramework", package: "FlutterFramework"),
],
resources: [
.process("Resources")
Expand Down
6 changes: 4 additions & 2 deletions packages/firebase_core/firebase_core/ios/firebase_core/Package.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,14 +19,16 @@ let package = Package(
.library(name: "firebase-core", targets: ["firebase_core"])
],
dependencies: [
.package(url: "https://github.com/firebase/firebase-ios-sdk", exact: firebaseSdkVersion)
.package(url: "https://github.com/firebase/firebase-ios-sdk", exact: firebaseSdkVersion),
.package(name: "FlutterFramework", path: "../FlutterFramework"),
],
targets: [
.target(
name: "firebase_core",
dependencies: [
// No product for firebase-core so we pull in the smallest one
.product(name: "FirebaseInstallations", package: "firebase-ios-sdk")
.product(name: "FirebaseInstallations", package: "firebase-ios-sdk"),
.product(name: "FlutterFramework", package: "FlutterFramework"),
],
resources: [
.process("Resources")
Expand Down
6 changes: 4 additions & 2 deletions packages/firebase_core/firebase_core/macos/firebase_core/Package.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,14 +19,16 @@ let package = Package(
.library(name: "firebase-core", targets: ["firebase_core"])
],
dependencies: [
.package(url: "https://github.com/firebase/firebase-ios-sdk", exact: firebaseSdkVersion)
.package(url: "https://github.com/firebase/firebase-ios-sdk", exact: firebaseSdkVersion),
.package(name: "FlutterFramework", path: "../FlutterFramework"),
],
targets: [
.target(
name: "firebase_core",
dependencies: [
// No product for firebase-core so we pull in the smallest one
.product(name: "FirebaseInstallations", package: "firebase-ios-sdk")
.product(name: "FirebaseInstallations", package: "firebase-ios-sdk"),
.product(name: "FlutterFramework", package: "FlutterFramework"),
],
resources: [
.process("Resources")
Expand Down
2 changes: 2 additions & 0 deletions packages/firebase_crashlytics/firebase_crashlytics/ios/firebase_crashlytics/Package.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,13 +21,15 @@ let package = Package(
dependencies: [
.package(url: "https://github.com/firebase/firebase-ios-sdk", exact: firebaseSdkVersion),
.package(name: "firebase_core", path: "../firebase_core"),
.package(name: "FlutterFramework", path: "../FlutterFramework"),
],
targets: [
.target(
name: "firebase_crashlytics",
dependencies: [
.product(name: "FirebaseCrashlytics", package: "firebase-ios-sdk"),
.product(name: "firebase-core", package: "firebase_core"),
.product(name: "FlutterFramework", package: "FlutterFramework"),
],
resources: [
.process("Resources")
Expand Down
2 changes: 2 additions & 0 deletions packages/firebase_crashlytics/firebase_crashlytics/macos/firebase_crashlytics/Package.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,13 +21,15 @@ let package = Package(
dependencies: [
.package(url: "https://github.com/firebase/firebase-ios-sdk", exact: firebaseSdkVersion),
.package(name: "firebase_core", path: "../firebase_core"),
.package(name: "FlutterFramework", path: "../FlutterFramework"),
],
targets: [
.target(
name: "firebase_crashlytics",
dependencies: [
.product(name: "FirebaseCrashlytics", package: "firebase-ios-sdk"),
.product(name: "firebase-core", package: "firebase_core"),
.product(name: "FlutterFramework", package: "FlutterFramework"),
],
resources: [
.process("Resources")
Expand Down
Loading
Loading