Skip to content

fix(android): remove plugin-local AGP and Kotlin Gradle Plugin pins from buildscript blocks - #18139

Merged
Lyokone merged 4 commits into
mainfrom
fix/18138
Aug 4, 2026
Merged

fix(android): remove plugin-local AGP and Kotlin Gradle Plugin pins from buildscript blocks#18139
Lyokone merged 4 commits into
mainfrom
fix/18138

Conversation

@Lyokone

@Lyokone Lyokone commented Mar 24, 2026

Copy link
Copy Markdown
Contributor

Description

Remove stale buildscript classpath declarations from Kotlin-based Android plugins. Several plugins were shipping classpath 'com.android.tools.build:gradle:8.1.4' and classpath("org.jetbrains.kotlin:kotlin-gradle-plugin:1.8.22") in their buildscript blocks, which can conflict with the app project's actual AGP/Kotlin versions and cause "cannot find symbol" errors during Java compilation.

Also removes a duplicate apply plugin: 'com.android.library' in firebase_analytics.

Affected plugins: cloud_functions, firebase_analytics, firebase_performance, firebase_storage, firebase_remote_config.

Related Issues

Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • My PR includes unit or integration tests for all changed/updated/fixed behaviors (See Contributor Guide).
  • All existing and new tests are passing.
  • I updated/added relevant documentation (doc comments with ///).
  • The analyzer (melos run analyze) does not report any problems on my PR.
  • I read and followed the Flutter Style Guide.
  • I signed the CLA.
  • I am willing to follow-up on review comments in a timely manner.

Breaking Change

  • Yes, this is a breaking change.
  • No, this is not a breaking change.

@gemini-code-assist

Copy link
Copy Markdown
Contributor
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

Lyokone added 3 commits August 4, 2026 09:46
Conflicts were confined to the buildscript blocks this PR removes: main
bumped ext.kotlin_version to 2.0.0 and the AGP classpath to 8.3.0 inside
them. Resolved by keeping the removals, since the declarations are the
legacy pattern being cleaned up. Kept main's updated builtInKotlin
comment in firebase_analytics.
firebase_app_check declared ext.kotlin_version but no longer had a
classpath referencing it, so the variable was dead. It already relies on
the consuming app for the Kotlin Gradle Plugin, same as firebase_database.
cloud_firestore pinned classpath 'com.android.tools.build:gradle:8.3.0'
in its own buildscript, which can conflict with the AGP version the
consuming app supplies. AGP is inherited from the root project, as it
already is in firebase_auth, firebase_core, firebase_messaging and
firebase_crashlytics.
@Lyokone Lyokone changed the title fix(android): clean old groovy style declaration in build.gradle files fix(android): remove plugin-local AGP and Kotlin Gradle Plugin pins from buildscript blocks Aug 4, 2026
@Lyokone
Lyokone merged commit 4f6960c into main Aug 4, 2026
42 of 47 checks passed
@Lyokone
Lyokone deleted the fix/18138 branch August 4, 2026 08:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[firebase_ai]: Android compilation failure

4 participants