Skip to content

fix: add two day rule sheet - #935

Merged
therobrob merged 3 commits into
mainfrom
fix/add-two-day-rule-sheet
May 12, 2026
Merged

therobrob merged 3 commits into
mainfrom
fix/add-two-day-rule-sheet

Conversation

@lenderom

@lenderom lenderom commented May 7, 2026 •

Copy link
Copy Markdown
Member

Fixes #931

@lenderom lenderom added the content Improvements or additions to the content (countries, news, operators, general content) label May 7, 2026
@github-actions

github-actions Bot commented May 7, 2026

Copy link
Copy Markdown

Hi there! 👋

Thank you for your contribution to the FIP Guide! 🚀
We appreciate your effort in making rail staff travel information more accessible. 🚄

Checklist before merging:

  • Added a description to the Pull Request
  • Checked the License of new pictures (non-commercial use without attribution)
  • Modified content in English
  • Modified content in German
  • Modified content in French

@netlify

netlify Bot commented May 7, 2026 •

Copy link
Copy Markdown

✅ Deploy Preview for fipguide ready!

Name Link
🔨 Latest commit cb17208
🔍 Latest deploy log https://app.netlify.com/projects/fipguide/deploys/6a038d31e956d600077b149b
😎 Deploy Preview https://deploy-preview-935--fipguide.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
🤖 Make changes Run an agent on this branch

To edit notification comments on pull requests, go to your Netlify project configuration.

@MoritzWeber0 MoritzWeber0 left a comment •

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we also make it available as single page in the FIP Guide so that it also scaled on mobile devices? We could still offer the downloadable version.

And we could link it on the FIP validity page too to the operators where we know that the fields are valid for two days.

@lenderom

lenderom commented May 9, 2026

Copy link
Copy Markdown
Member Author

Should we also make it available as single page in the FIP Guide so that it also scaled on mobile devices? We could still offer the downloadable version.

And we could link it on the FIP validity page too to the operators where we know that the fields are valid for two days.

I'm not so sure what the benefit or goal of such an page would be. At the moment I focus on the usecase: "Showing the trains staff a semi-official document to help understanding the rules". I think a scaling responsive site seems less "official" if you know what I mean.

I'm not totallay against such a page, but don't see the benefit at the moment to be honest.

@therobrob therobrob left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree with Lennart that i don't see the benefit for an separate page.

@therobrob
therobrob merged commit ad7d7ab into main May 12, 2026
7 checks passed
@therobrob
therobrob deleted the fix/add-two-day-rule-sheet branch May 12, 2026 20:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

content Improvements or additions to the content (countries, news, operators, general content)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add 2 day rule translation sheet for print out

3 participants