Repository navigation
SVGs: Use of <use> - #297
Merged
Merged
Conversation
therobrob
added
the
technical
✅ Deploy Preview for fipguide ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
therobrob
marked this pull request as ready for review
August 31, 2025 16:26
MoritzWeber0
previously approved these changes
Sep 1, 2025
MoritzWeber0
left a comment
MoritzWeber0
left a comment
Member
There was a problem hiding this comment.
Cool improvement, didn't know about the use-tag before and learned something new. Just two comments for my understanding, they should not block the merge.
MoritzWeber0
approved these changes
Sep 2, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
With svg use we don’t have to add them to DOM directly, but can change the color in dark mode.