Skip to content

feat: Improve dark mode - #267

Merged
MoritzWeber0 merged 14 commits into
mainfrom
feat/dark-mode-improvements
Aug 29, 2025
Merged

MoritzWeber0 merged 14 commits into
mainfrom
feat/dark-mode-improvements

Conversation

@therobrob

@therobrob therobrob commented Jul 28, 2025 •

Copy link
Copy Markdown
Member

I've done some improvements for dark mode. Boxes and Cards now stand out more from the background. The logo and intersectors now react on color change.

removed menu.html (see #257)
renamed logo.html
fip guide logo on dark
fip guide logo on dark
fallback for rss-feed
fallback for rss-feed
dark-mode for intersector.html
dark-mode for intersector.html
smaller improvements
@netlify

netlify Bot commented Jul 28, 2025 •

Copy link
Copy Markdown

✅ Deploy Preview for fipguide ready!

Name Link
🔨 Latest commit a2456f4
🔍 Latest deploy log https://app.netlify.com/projects/fipguide/deploys/68b150d6de0df300088f091e
😎 Deploy Preview https://deploy-preview-267--fipguide.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

smaller improvements
@therobrob
therobrob requested a review from MoritzWeber0 July 28, 2025 22:03
smaller improvements
@MoritzWeber0 MoritzWeber0 changed the title Dark Mode Improvements feat: Improve dark mode Jul 31, 2025

@MoritzWeber0 MoritzWeber0 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good improvement, I like the new color scheme. Thanks for adjusting the logo, that's definitely a part that was missing. We should rethink the way the logo and dividers are embedded, more about it in the comment section.

Comment thread layouts/partials/intersector.html
Comment thread layouts/partials/header-logo.html
Comment thread assets/sass/_variables.scss
@therobrob therobrob closed this Jul 31, 2025
@therobrob

Copy link
Copy Markdown
Member Author

My work seems not to be good enough for you, so I’ve closed the PR.

@MoritzWeber0

Copy link
Copy Markdown
Member

My work seems not to be good enough for you, so I’ve closed the PR.

I like the changes, so if that wasn't clear from the comment, I'm sorry. We can also take another look at the topics together if you'd like :)

@therobrob therobrob reopened this Aug 20, 2025
@therobrob
therobrob requested a review from MoritzWeber0 August 29, 2025 07:05
@MoritzWeber0
MoritzWeber0 merged commit fca101c into main Aug 29, 2025
7 checks passed
@MoritzWeber0
MoritzWeber0 deleted the feat/dark-mode-improvements branch August 29, 2025 20:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants