chore(deps): bump vitest to v4 and fix tests#1564
Conversation
✅ Deploy Preview for endearing-brigadeiros-63f9d0 canceled.
|
Dependency ReviewThe following issues were found:
|
Prevents EADDRINUSE error on parallel test execution, drastically speeds up test execution
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1564 +/- ##
==========================================
- Coverage 85.75% 84.09% -1.67%
==========================================
Files 85 81 -4
Lines 8448 4891 -3557
Branches 1457 843 -614
==========================================
- Hits 7245 4113 -3132
+ Misses 1172 555 -617
- Partials 31 223 +192 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
|
The dependency review is complaining on This is a known issue with Dependency Review not falling back to the GH license fetch API when the dependency graph API doesn't fetch as intended: actions/dependency-review-action#704 |
cccface to
96cbd3e
Compare
kriswest
left a comment
There was a problem hiding this comment.
Needs conflicts resolved then good to go. One question (out of curiosity)
| reviewer: { | ||
| username: string; | ||
| email: string; | ||
| gitAccount?: string; // Legacy field for GitHub usernames |
There was a problem hiding this comment.
what prompted this coming back?
There was a problem hiding this comment.
I think I added that again because of the following error on npm run check-types:
This is being used by the frontend to render legacy GitHub-only usernames:
<>
{isGitHub && (
<UserLink username={push.attestation.reviewer.username}>
<img
style={{ width: '45px', borderRadius: '20px' }}
src={`https://github.com/${push.attestation.reviewer.gitAccount}.png`}
/>
</UserLink>
)}
<div>
<p>
{isGitHub && (
<UserLink username={push.attestation.reviewer.username}>
{push.attestation.reviewer.gitAccount}
</UserLink>
)}
{!isGitHub && <UserLink username={push.attestation.reviewer.username} />} approved
this contribution
</p>
</div>
</>This type error can still be viewed on main when running npm run check-types. The CI executes on the server-side only, hence why we didn't see this before: npm run check-types:server
Description
Bumps Vitest to v4 and fixes resulting failing tests from syntax changes.
Despite adding the
uiPortmocks to fix someEADDRINUSEerrors when running tests in parallel, I decided to keep the sequential tests (by disabling thefileParallelismoption, formerlypoolOptions.forks.singleFork).This is because a few tests still fail when running
npm run test-shuffle, and the MongoDB integration tests also fail on the CI when enabling parallelism. I made an issue to track this so we can benefit from parallel test execution speedup: #1565Checklist
General
Tests
npm test)npm run lintandnpm run format:check)npm run check-types)