Feature solver - #26
Conversation
|
LGTM! |
skadio
left a comment
There was a problem hiding this comment.
Checking if this approval works/possible.
|
(let me know if you need help in updating pypi) |
@skadio thanks for offering to help. Please feel free to proceed. |
There was a problem hiding this comment.
Thank you @rbaral ! PR looks good to me. Please also update the changelog and the version. It might be a version 1.3.0? This is where version is applied feature/_version.py when install.
|
|
||
| This method identifies the appropriate model context (regression vs. classification), | ||
| fits it to the training data, and extracts the coefficient weights. For multi-class | ||
| classifiers, it computes a global score by averaging the class-specific absolute weights. |
|
|
@skadio @takojunior It looks like I do not have upload access. I updated the changelog and upgraded version to 1.2.1. Can you help with uploading to pypi? |
I have the maintainer role for selective on pypi. I should be able to help upload to pypi if ok. @skadio @rbaral |
Context:
This PR provides the solution to the issue Linear Selection Method fails with Python 3.12 (#24). The issue is about the Linear selection failing because the scikit-learn does not support
multi_classattribute for LogisticRegressionSee more context and replication steps at #24
Fix:
__init__()method, use the OneVsRestClassifier to wrap the LogisticRegression and remove the multi_class attribute.process_category_data()method@takojunior @kuppulur @skadio @wddcheng Can you please help with the PR review?