fix(connectors): report connectivity for iroh-next connections - #8987
Open
joschisan wants to merge 1 commit into
Open
fix(connectors): report connectivity for iroh-next connections#8987joschisan wants to merge 1 commit into
joschisan wants to merge 1 commit into
Conversation
joschisan
force-pushed
the
fix-iroh-next-connectivity-status
branch
from
August 9, 2026 18:41
3d4e246 to
78310f6
Compare
`IrohConnector::connectivity` only ever queried the stable (0.35) endpoint, so a peer reached over an advertised iroh 1.0 endpoint resolved to `Connectivity::Unknown`, which the api client maps to `PeerStatus::Disconnected` — a live guardian shown as offline. Iroh 1.0 exposes path state per connection rather than per endpoint, so there is no `endpoint.conn_type(node_id)` to consult after the fact. Retain next-stack connections at dial time and classify from `Connection::paths()` instead, falling back to the stable endpoint when no live next connection is held. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
joschisan
force-pushed
the
fix-iroh-next-connectivity-status
branch
from
August 9, 2026 18:53
78310f6 to
2786e72
Compare
joschisan
marked this pull request as ready for review
August 9, 2026 19:49
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
IrohConnector::connectivityonly queried the stable (0.35) endpoint, so a peer reached over an advertised iroh 1.0 endpoint resolved toConnectivity::Unknown, which the api client maps toPeerStatus::Disconnected— a live guardian shown as offline.Iroh 1.0 exposes path state per connection rather than per endpoint, so next-stack connections are now retained at dial time and classified from
Connection::paths(), falling back to the stable endpoint when no live next connection is held.