Conversation
moonglum
commented
Mar 13, 2026
| "dependencies": { | ||
| "@rollup/plugin-commonjs": "~29.0.1", | ||
| "@rollup/plugin-node-resolve": "~16.0.3", | ||
| "browserslist": "^4.28.1", |
Member
Author
There was a problem hiding this comment.
Note that this doesn't add a dependency, as this is currently a transitive dependency via core
moonglum
commented
Mar 13, 2026
|
|
||
| function faucetJS(config, assetManager, { browsers, compact, sourcemaps } = {}) { | ||
| function faucetJS(config, assetManager, { compact, sourcemaps } = {}) { | ||
| let browsers = browserslist.findConfig(assetManager.referenceDir) || {}; |
Member
Author
There was a problem hiding this comment.
This basically just moves the code that is deleted in core in this PR:
https://github.com/faucet-pipeline/faucet-pipeline-core/pull/168/changes
Member
Author
|
@FND Do you understand why the tests fail? I don't really get it. |
Member
Author
|
After removing the deprecated options, we have the following configuration options left:
I think this will allow us to give esbuild another try for the next major version:
I would argue that there should only be to options for compact:
Note that compact only has an effect if you run faucet with |
Member
Author
|
Changes merged into #236 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposal for changes in v3.1: